Spec URL: https://music.fedorapeople.org/python-opentelemetry-propagator-aws-xray.spec SRPM URL: https://music.fedorapeople.org/python-opentelemetry-propagator-aws-xray-1.0.1-1.fc39.src.rpm Description: This library provides the propagator necessary to inject or extract a tracing context across AWS services. Fedora Account System Username: music This review doesn’t exactly fall under https://docs.fedoraproject.org/en-US/package-maintainers/Package_Renaming_Process/ or even https://docs.fedoraproject.org/en-US/packaging-guidelines/#renaming-or-replacing-existing-packages, but they are somewhat relevant. The binary package produced by this new package, python3-opentelemetry-propagator-aws-xray, is currently built as part of https://src.fedoraproject.org/rpms/python-opentelemetry-contrib. The goal of packaging it separately is to split out parts of https://github.com/open-telemetry/opentelemetry-python-contrib that carry separate version numbers, which complicates the python-opentelemetry-contrib and is particularly a headache for managing the release number in that package; currently, the release needs to increment monotonically forever unless all versions change at once. The python3-opentelemetry-propagator-aws-xray subpackage of python-opentelemetry-contrib will be dropped at the same time this package is imported. To provide a proper upgrade path, the Release number of this package starts at 52, where python-opentelemetry-contrib is currently at 51. I decided that this was less ugly than starting with an Epoch. At the same time, I will adjust the dependencies on python3-opentelemetry-propagator-aws-xray from python3-opentelemetry-instrumentation-aws-lambda and python3-opentelemetry-instrumentation-botocore so that they are no longer fully-versioned (exact version and release as in https://docs.fedoraproject.org/en-US/packaging-guidelines/#_requiring_base_package).
Copr build: https://copr.fedorainfracloud.org/coprs/build/7007689 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2263732-python-opentelemetry-propagator-aws-xray/fedora-rawhide-x86_64/07007689-python-opentelemetry-propagator-aws-xray/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed No issues found here. Good job! Approved. ✅ ===== MUST items ===== Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [X]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 9633 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Binary eggs must be removed in %prep Note: Cannot find any build in BUILD directory (--prebuilt option?) [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: python3-opentelemetry-propagator-aws-xray-1.0.1-1.fc39.noarch.rpm python-opentelemetry-propagator-aws-xray-1.0.1-1.fc39.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp74ylj9se')] checks: 31, packages: 2 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.2 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "python3-opentelemetry-propagator-aws-xray". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://github.com/open-telemetry/opentelemetry-python-contrib/archive/opentelemetry-propagator-aws-xray%3D%3D1.0.1/opentelemetry-python-contrib-opentelemetry-propagator-aws-xray-1.0.1.tar.gz : CHECKSUM(SHA256) this package : 36847abe90460a9c5d439a44a310280c67740159ad30360edb06e0d4c1c5f250 CHECKSUM(SHA256) upstream package : 36847abe90460a9c5d439a44a310280c67740159ad30360edb06e0d4c1c5f250 Requires -------- python3-opentelemetry-propagator-aws-xray (rpmlib, GLIBC filtered): (python3.12dist(opentelemetry-api) >= 1.3 with python3.12dist(opentelemetry-api) < 2) python(abi) Provides -------- python3-opentelemetry-propagator-aws-xray: python-opentelemetry-propagator-aws-xray python3-opentelemetry-propagator-aws-xray python3.12-opentelemetry-propagator-aws-xray python3.12dist(opentelemetry-propagator-aws-xray) python3dist(opentelemetry-propagator-aws-xray) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name python-opentelemetry-propagator-aws-xray --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-39-x86_64 Active plugins: Generic, Shell-api, Python Disabled plugins: R, Haskell, PHP, C/C++, Java, Ocaml, SugarActivity, fonts, Perl Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Thank you for the review! For simplicity, I’ll wait to adjust python-opentelemetry-contrib and do the initial builds of this package, python-opentelemetry-sdk-extension-aws (bug 2263734), and python-opentelemetry-resource-detector-azure (bug 2263742) all at the same time.
https://release-monitoring.org/project/371541/
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-opentelemetry-propagator-aws-xray
FEDORA-2024-06da2a8704 (python-opentelemetry-contrib-1.22.0-52.fc41, python-opentelemetry-propagator-aws-xray-1.0.1-52.fc41, and 2 more) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-06da2a8704
FEDORA-2024-06da2a8704 (python-opentelemetry-contrib-1.22.0-52.fc41, python-opentelemetry-propagator-aws-xray-1.0.1-52.fc41, and 2 more) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-e1ffd5d470 (python-opentelemetry-contrib-1.22.0-52.fc40, python-opentelemetry-propagator-aws-xray-1.0.1-52.fc40, and 2 more) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-e1ffd5d470
FEDORA-2024-e1ffd5d470 (python-opentelemetry-contrib-1.22.0-52.fc40, python-opentelemetry-propagator-aws-xray-1.0.1-52.fc40, and 2 more) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.