Bug 2270220

Summary:	mgr/snap_schedule: make monthly spec consistent with other parts of ceph
Product:	[Red Hat Storage] Red Hat Ceph Storage	Reporter:	Milind Changire <mchangir>
Component:	CephFS	Assignee:	Milind Changire <mchangir>
Status:	CLOSED ERRATA	QA Contact:	Amarnath <amk>
Severity:	medium	Docs Contact:	Akash Raj <akraj>
Priority:	unspecified
Version:	7.0	CC:	akraj, amk, ceph-eng-bugs, cephqe-warriors, gfarnum, hyelloji, jcaratza, sostapov, sumr, tserlin, vereddy, vimishra, vshankar
Target Milestone:	---
Target Release:	6.1z5
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	ceph-17.2.6-209.el9cp	Doc Type:	Bug Fix
Doc Text:	Previously, the snap-schedule repeat specification and retention specification for monthly snapshots was not consistent with other Ceph components. With this fix, the specifications are changed from 'm' to 'M' and it is now consistent with other Ceph components. For example, to retain 5 monthly snapshots, you need to issue the following command: ---- # ceph fs snap-schedule retention add /some/path M 5 ----	Story Points:	---
Clone Of:	2264348
Clones:	2272936 (view as bug list)		Environment:
Last Closed:	2024-04-01 10:20:17 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	2264348
Bug Blocks:	2267617, 2272936

Description Milind Changire 2024-03-19 03:52:48 UTC

+++ This bug was initially created as a clone of Bug #2264348 +++

Description of problem:
There is inconsistency in the way the month spec (m) is defined for cephfs snap_schedule and rbd mirror (M)


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:
m -> minute
M -> month

Additional info:
with this change, QE will need update cephfs snapshot schedule tests to use 'm' for minute level snapshots and 'M' for monthly snapshots.

--- Additional comment from RHEL Program Management on 2024-02-15 11:56:42 IST ---

Please specify the severity of this bug. Severity is defined here:
https://bugzilla.redhat.com/page.cgi?id=fields.html#bug_severity.

--- Additional comment from Milind Changire on 2024-02-16 09:53:29 IST ---

MR - https://gitlab.cee.redhat.com/ceph/ceph/-/merge_requests/489

--- Additional comment from Venky Shankar on 2024-02-16 10:50:01 IST ---

(In reply to Milind Changire from comment #2)
> MR - https://gitlab.cee.redhat.com/ceph/ceph/-/merge_requests/489

Merged.

--- Additional comment from  on 2024-02-17 10:55:05 IST ---

Builds are ready for testing. We need a qa_ack+ in order to attach this BZ to the errata advisory and move to ON_QA.

--- Additional comment from errata-xmlrpc on 2024-02-20 20:58:59 IST ---

This bug has been added to advisory RHBA-2024:126567 by Thomas Serlin (tserlin)

--- Additional comment from errata-xmlrpc on 2024-02-20 20:59:02 IST ---

Bug report changed to ON_QA status by Errata System.
A QE request has been submitted for advisory RHBA-2024:126567-01
https://errata.engineering.redhat.com/advisory/126567

--- Additional comment from errata-xmlrpc on 2024-02-20 20:59:09 IST ---

This bug has been added to advisory RHBA-2024:126567 by Thomas Serlin (tserlin)

--- Additional comment from  on 2024-03-08 11:19:36 IST ---

Test Plan:
- Make required changes( 'M' to 'm' for minutely schedule interval) in existing snap schedule automated regression runs and validate test coverage with 'm'.

--- Additional comment from  on 2024-03-08 11:25:54 IST ---

(In reply to sumr from comment #8)
> Test Plan:
> - Make required changes( 'M' to 'm' for minutely schedule interval) in
> existing snap schedule automated regression runs and validate test coverage
> with 'm'.

Regression test logs with required fix : http://magna002.ceph.redhat.com/cephci-jenkins/cephci-run-N308A3/snap_schedule_retention_vol_subvol_0.log

Marking the BZ as VERIFIED as existing snap schedule regression tests works with 'm' for minutely schedule.

--- Additional comment from Akash Raj on 2024-03-14 10:41:52 IST ---

Hi Venky

Please confirm if the doc text for this BZ needs to be added in the release notes. If yes, please provide the doc type and text.

Thanks.

--- Additional comment from Venky Shankar on 2024-03-14 10:47:10 IST ---

(In reply to Akash Raj from comment #10)
> Hi Venky
> 
> Please confirm if the doc text for this BZ needs to be added in the release
> notes. If yes, please provide the doc type and text.

This is a major change and requires doc_text updated. cc Milind - please do the needful.

Comment 2 Scott Ostapovicz 2024-03-19 13:08:52 UTC

This BZ was targeted to z5 after the date when it should have been targeted at z6.

Comment 20 errata-xmlrpc 2024-04-01 10:20:17 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Red Hat Ceph Storage 6.1 Bug Fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2024:1580