Bug 2279539
| Summary: | Review Request: rust-sqlx-macros-core - Macro support core for SQLx, the Rust SQL toolkit | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Cristian Le <fedora> |
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | decathorpe, eclipseo, package-review |
| Target Milestone: | --- | Flags: | decathorpe:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://crates.io/crates/sqlx-macros-core | ||
| Whiteboard: | |||
| Fixed In Version: | rust-sqlx-macros-core-0.8.2-1.fc42 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2024-09-15 12:47:21 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 2279537, 2279542, 2279544, 2279546 | ||
| Bug Blocks: | 2279540 | ||
|
Description
Cristian Le
2024-05-07 12:16:02 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/7424565 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2279539-rust-sqlx-macros-core/fedora-rawhide-x86_64/07424565-rust-sqlx-macros-core/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. - Grab license files from https://github.com/launchbadge/sqlx and reference this bug for resolution of the situation: https://github.com/launchbadge/sqlx/issues/3237 - License ok - Latest version packaged - Builds in mock - Checks pass - No rpmlint errors - Conforms to Go Packaging Guidelines Package approved. see also my comment here: https://bugzilla.redhat.com/show_bug.cgi?id=2279542#c3 Spec URL: https://github.com/LecrisUT/sqlx-rpmspec/raw/bcb99b4c4cf9566d8da58eb5eb90b0f26257fd3f/rust-sqlx-macros-core/rust-sqlx-macros-core.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/packit/LecrisUT-sqlx-rpmspec-main/fedora-rawhide-x86_64/07475523-rust-sqlx-macros-core/rust-sqlx-macros-core-0.7.4-1.fc41.src.rpm rust2rpm.toml: (Edited `%files devel` after running `rust2rpm -I`) ```toml [[package.extra-sources]] number = 10 file = "https://github.com/launchbadge/sqlx/raw/v%{version}/LICENSE-APACHE" comments = [ "Fix missing LICENSE-* files in released crates", "https://github.com/launchbadge/sqlx/issues/3237", ] [[package.extra-sources]] number = 11 file = "https://github.com/launchbadge/sqlx/raw/v%{version}/LICENSE-MIT" comments = [ "Fix missing LICENSE-* files in released crates", "https://github.com/launchbadge/sqlx/issues/3237", ] [scripts.prep] pre = ["cp -p '%{SOURCE10}' '%{SOURCE11}' ."] [package] extra-files = [ "%license %{crate_instdir}/LICENSE-APACHE", "%license %{crate_instdir}/LICENSE-MIT", ] ``` Spec URL: https://lecris.fedorapeople.org/reviews/rust-sqlx-macros-core/rust-sqlx-macros-core.spec SRPM URL: https://lecris.fedorapeople.org/reviews/rust-sqlx-macros-core/rust-sqlx-macros-core-0.8.1-1.fc42.src.rpm Bump sqlx packages to 0.8.1 Spec URL: https://lecris.fedorapeople.org/reviews/rust-sqlx-macros-core/rust-sqlx-macros-core.spec SRPM URL: https://lecris.fedorapeople.org/reviews/rust-sqlx-macros-core/rust-sqlx-macros-core-0.8.2-1.fc42.src.rpm Bumped to 0.8.2 Copr build: https://copr.fedorainfracloud.org/coprs/build/8010409 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2279539-rust-sqlx-macros-core/fedora-rawhide-x86_64/08010409-rust-sqlx-macros-core/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license files are included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) Thank you for the review, Fabio The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-sqlx-macros-core FEDORA-2024-8b29ea4a35 (rust-sqlx-macros-core-0.8.2-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2024-8b29ea4a35 FEDORA-2024-8b29ea4a35 (rust-sqlx-macros-core-0.8.2-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report. |