Bug 2279542 - Review Request: rust-sqlx-mysql - MySQL driver implementation for SQLx
Summary: Review Request: rust-sqlx-mysql - MySQL driver implementation for SQLx
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/sqlx-mysql
Whiteboard:
Depends On: 2268045 2279536 2279537 2310831
Blocks: 2279539 2279547
TreeView+ depends on / blocked
 
Reported: 2024-05-07 12:23 UTC by Cristian Le
Modified: 2024-09-12 11:44 UTC (History)
3 users (show)

Fixed In Version: rust-sqlx-mysql-0.8.2-1.fc42
Clone Of:
Environment:
Last Closed: 2024-09-12 11:44:46 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Cristian Le 2024-05-07 12:23:08 UTC
Spec URL: https://github.com/LecrisUT/sqlx-rpmspec/raw/b8d1b82fdbcf7e5292f2c61076ac42c6f84cee7b/rust-sqlx-mysql/rust-sqlx-mysql.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/packit/LecrisUT-sqlx-rpmspec-main/fedora-rawhide-x86_64/07376139-rust-sqlx-mysql/rust-sqlx-mysql-0.7.4-1.fc41.src.rpm
Description: Part of `sqlx`
Fedora Account System Username: lecris

rust2rpm.toml:
```toml
[tests]
skip = [
    "options::MySqlConnectOptions",
]
comments = [
    "Skip tests that require main sqlx package"
]
```

Comment 1 Fedora Review Service 2024-05-07 12:26:30 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7424579
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2279542-rust-sqlx-mysql/fedora-rawhide-x86_64/07424579-rust-sqlx-mysql/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Robert-André Mauchin 🐧 2024-05-21 16:38:44 UTC
 - Grab license files from https://github.com/launchbadge/sqlx and reference this bug for resolution of the situation:

https://github.com/launchbadge/sqlx/issues/3237

- License ok
- Latest version packaged
- Builds in mock
- Checks pass
- No rpmlint errors
- Conforms to Go Packaging Guidelines

Package approved.

Comment 3 Fabio Valentini 2024-05-21 18:21:04 UTC
> - Conforms to Go Packaging Guidelines

Looks like you pasted the wrong template? :)

Also, compared to Go packages, it's also necessary that all built packages *install* without missing dependencies. Did you verify this?

Comment 4 Cristian Le 2024-05-22 10:00:22 UTC
Spec URL: https://github.com/LecrisUT/sqlx-rpmspec/raw/bcb99b4c4cf9566d8da58eb5eb90b0f26257fd3f/rust-sqlx-mysql/rust-sqlx-mysql.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/packit/LecrisUT-sqlx-rpmspec-main/fedora-rawhide-x86_64/07475520-rust-sqlx-mysql/rust-sqlx-mysql-0.7.4-1.fc41.src.rpm

rust2rpm.toml:
```toml
[[package.extra-sources]]
number = 10
file = "https://github.com/launchbadge/sqlx/raw/v%{version}/LICENSE-APACHE"
comments = [
    "Fix missing LICENSE-* files in released crates",
    "https://github.com/launchbadge/sqlx/issues/3237",
]
[[package.extra-sources]]
number = 11
file = "https://github.com/launchbadge/sqlx/raw/v%{version}/LICENSE-MIT"
comments = [
    "Fix missing LICENSE-* files in released crates",
    "https://github.com/launchbadge/sqlx/issues/3237",
]

[scripts.prep]
pre = ["cp -p '%{SOURCE10}' '%{SOURCE11}' ."]

[package]
extra-files = [
    "%license %{crate_instdir}/LICENSE-APACHE",
    "%license %{crate_instdir}/LICENSE-MIT",
]

[tests]
skip = [
    "options::MySqlConnectOptions",
]
comments = [
    "Skip tests that require main sqlx package"
]
```

Comment 5 Cristian Le 2024-07-08 11:33:23 UTC
Similar change to https://bugzilla.redhat.com/show_bug.cgi?id=2279546#c6

---

Spec URL: https://github.com/LecrisUT/sqlx-rpmspec/raw/8a8d6c3c423c1e9b24ca1a557a32f3df1d0ff38f/rust-sqlx-mysql/rust-sqlx-mysql.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/packit/LecrisUT-sqlx-rpmspec-main/fedora-rawhide-x86_64/07714406-rust-sqlx-mysql/rust-sqlx-mysql-0.7.4-1.fc41.src.rpm

rust2rpm.toml:
```toml
[features]
enable-all = true

[[package.extra-sources]]
number = 10
file = "https://github.com/launchbadge/sqlx/raw/v%{version}/LICENSE-APACHE"
comments = [
    "Fix missing LICENSE-* files in released crates",
    "https://github.com/launchbadge/sqlx/issues/3237",
]
[[package.extra-sources]]
number = 11
file = "https://github.com/launchbadge/sqlx/raw/v%{version}/LICENSE-MIT"
comments = [
    "Fix missing LICENSE-* files in released crates",
    "https://github.com/launchbadge/sqlx/issues/3237",
]

[scripts.prep]
pre = ["cp -p '%{SOURCE10}' '%{SOURCE11}' ."]

[package]
cargo-toml-patch-comments = [
    "- Fix missing chrono.clock feature",
    "  https://github.com/launchbadge/sqlx/issues/3332",
]


[tests]
skip = [
    "options::MySqlConnectOptions",
]
comments = [
    "Skip tests that require main sqlx package"
]
```

sqlx-mysql-fix-metadata.diff
```
--- sqlx-mysql-0.7.4/Cargo.toml	1970-01-01T00:00:01+00:00
+++ sqlx-mysql-0.7.4/Cargo.toml	2024-07-07T08:49:46.239326+00:00
@@ -51,6 +51,9 @@
 
 [dependencies.chrono]
 version = "0.4.22"
+features = [
+    "clock",
+]
 optional = true
 default-features = false
 
```

Comment 6 Fedora Review Service 2024-07-09 12:37:13 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7719760
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2279542-rust-sqlx-mysql/fedora-rawhide-x86_64/07719760-rust-sqlx-mysql/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 7 Package Review 2024-08-08 00:45:29 UTC
This is an automatic action taken by review-stats script.

The ticket reviewer failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we reset the status and the assignee of this ticket.

Comment 9 Fedora Review Service 2024-08-27 16:04:08 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7947981
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2279542-rust-sqlx-mysql/fedora-rawhide-x86_64/07947981-rust-sqlx-mysql/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 11 Fedora Review Service 2024-09-12 00:29:40 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8010406
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2279542-rust-sqlx-mysql/fedora-rawhide-x86_64/08010406-rust-sqlx-mysql/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 12 Fabio Valentini 2024-09-12 11:16:28 UTC
Package was generated with rust2rpm, simplifying the review.

βœ… package contains only permissible content
βœ… package builds and installs without errors on rawhide
βœ… test suite is run and all unit tests pass (one test disabled with justification)
βœ… latest version of the crate is packaged
βœ… license matches upstream specification and is acceptable for Fedora
βœ… license file is included with %license in %files
βœ… package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 13 Cristian Le 2024-09-12 11:21:37 UTC
Thank you for the review, Fabio

Comment 14 Fedora Admin user for bugzilla script actions 2024-09-12 11:21:52 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-sqlx-mysql

Comment 15 Fedora Update System 2024-09-12 11:42:39 UTC
FEDORA-2024-6e13919777 (rust-sqlx-mysql-0.8.2-1.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-6e13919777

Comment 16 Fedora Update System 2024-09-12 11:44:46 UTC
FEDORA-2024-6e13919777 (rust-sqlx-mysql-0.8.2-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.