Spec URL: https://github.com/LecrisUT/sqlx-rpmspec/raw/b8d1b82fdbcf7e5292f2c61076ac42c6f84cee7b/rust-sqlx-sqlite/rust-sqlx-sqlite.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/packit/LecrisUT-sqlx-rpmspec-main/fedora-rawhide-x86_64/07376141-rust-sqlx-sqlite/rust-sqlx-sqlite-0.7.4-1.fc41.src.rpm Description: Part of `sqlx` Fedora Account System Username: lecris rust2rpm.toml: ```toml [[package.extra-patches]] comments = [ "https://github.com/launchbadge/sqlx/pull/3148", "Also fix libsqlite3 features", ] file = "sqlx-sqlite-0.7.4-Fix_libsqlite3-sys.patch" number = 10 [tests] comments = [ "resolve dependency loop with sqlx", ] run = ["none"] ```
Copr build: https://copr.fedorainfracloud.org/coprs/build/7424589 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2279546-rust-sqlx-sqlite/fedora-rawhide-x86_64/07424589-rust-sqlx-sqlite/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
- Grab license files from https://github.com/launchbadge/sqlx and reference this bug for resolution of the situation: https://github.com/launchbadge/sqlx/issues/3237 - License ok - Latest version packaged - Builds in mock - Checks pass - No rpmlint errors - Conforms to Go Packaging Guidelines Package approved.
see also my comment here: https://bugzilla.redhat.com/show_bug.cgi?id=2279542#c3
Spec URL: https://github.com/LecrisUT/sqlx-rpmspec/raw/bcb99b4c4cf9566d8da58eb5eb90b0f26257fd3f/rust-sqlx-sqlite/rust-sqlx-sqlite.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/packit/LecrisUT-sqlx-rpmspec-main/fedora-rawhide-x86_64/07475522-rust-sqlx-sqlite/rust-sqlx-sqlite-0.7.4-1.fc41.src.rpm Description: Part of `sqlx` Fedora Account System Username: lecris rust2rpm.toml: ```toml [[package.extra-sources]] number = 10 file = "https://github.com/launchbadge/sqlx/raw/v%{version}/LICENSE-APACHE" comments = [ "Fix missing LICENSE-* files in released crates", "https://github.com/launchbadge/sqlx/issues/3237", ] [[package.extra-sources]] number = 11 file = "https://github.com/launchbadge/sqlx/raw/v%{version}/LICENSE-MIT" comments = [ "Fix missing LICENSE-* files in released crates", "https://github.com/launchbadge/sqlx/issues/3237", ] [scripts.prep] pre = ["cp -p '%{SOURCE10}' '%{SOURCE11}' ."] [package] extra-files = [ "%license %{crate_instdir}/LICENSE-APACHE", "%license %{crate_instdir}/LICENSE-MIT", ] [[package.extra-patches]] comments = [ "https://github.com/launchbadge/sqlx/pull/3148", "Also fix libsqlite3 features", ] file = "sqlx-sqlite-0.7.4-Fix_libsqlite3-sys.patch" number = 10 [tests] comments = [ "resolve dependency loop with sqlx", ] run = ["none"] ```
Adding a patch for https://github.com/launchbadge/sqlx/pull/3281 --- Spec URL: https://github.com/LecrisUT/sqlx-rpmspec/raw/227de9cd3f36532deebfda883cac9bf44ba2587e/rust-sqlx-sqlite/rust-sqlx-sqlite.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/packit/LecrisUT-sqlx-rpmspec-main/fedora-rawhide-x86_64/07596534-rust-sqlx-sqlite/rust-sqlx-sqlite-0.7.4-1.fc41.src.rpm rust2rpm.toml: ```toml [[package.extra-sources]] number = 10 file = "https://github.com/launchbadge/sqlx/raw/v%{version}/LICENSE-APACHE" comments = [ "Fix missing LICENSE-* files in released crates", "https://github.com/launchbadge/sqlx/issues/3237", ] [[package.extra-sources]] number = 11 file = "https://github.com/launchbadge/sqlx/raw/v%{version}/LICENSE-MIT" comments = [ "Fix missing LICENSE-* files in released crates", "https://github.com/launchbadge/sqlx/issues/3237", ] [scripts.prep] pre = ["cp -p '%{SOURCE10}' '%{SOURCE11}' ."] [package] extra-files = [ "%license %{crate_instdir}/LICENSE-APACHE", "%license %{crate_instdir}/LICENSE-MIT", ] cargo-toml-patch-comments = [ "- Bump libsqlite3 dependency: https://github.com/launchbadge/sqlx/pull/3148", "- Fix libsqlite3 features", ] [[package.extra-patches]] comments = [ "https://github.com/launchbadge/sqlx/pull/3281", "Add SQLITE_OPEN_URI to all in-memory sqlite", ] file = "sqlx-sqlite-0.7.4-Fix_openuri_flag.patch" number = 10 [tests] comments = [ "resolve dependency loop with sqlx", ] run = ["none"] ```
I've had to fix more dependencies and stuff. Robert can you re-review? --- Spec URL: https://github.com/LecrisUT/sqlx-rpmspec/raw/8a8d6c3c423c1e9b24ca1a557a32f3df1d0ff38f/rust-sqlx-sqlite/rust-sqlx-sqlite.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/packit/LecrisUT-sqlx-rpmspec-main/fedora-rawhide-x86_64/07714408-rust-sqlx-sqlite/rust-sqlx-sqlite-0.7.4-1.fc41.src.rpm rust2rpm.toml: ```toml [features] enable-all = true [[package.extra-sources]] number = 10 file = "https://github.com/launchbadge/sqlx/raw/v%{version}/LICENSE-APACHE" comments = [ "Fix missing LICENSE-* files in released crates", "https://github.com/launchbadge/sqlx/issues/3237", ] [[package.extra-sources]] number = 11 file = "https://github.com/launchbadge/sqlx/raw/v%{version}/LICENSE-MIT" comments = [ "Fix missing LICENSE-* files in released crates", "https://github.com/launchbadge/sqlx/issues/3237", ] [scripts.prep] pre = ["cp -p '%{SOURCE10}' '%{SOURCE11}' ."] [package] cargo-toml-patch-comments = [ "- Bump libsqlite3 dependency", " https://github.com/launchbadge/sqlx/pull/3148", "- Fix libsqlite3 features", "- Fix missing chrono.clock feature", " https://github.com/launchbadge/sqlx/issues/3332", ] [[package.extra-patches]] comments = [ "https://github.com/launchbadge/sqlx/pull/3281", "Add SQLITE_OPEN_URI to all in-memory sqlite", ] file = "sqlx-sqlite-0.7.4-Fix_openuri_flag.patch" number = 10 [tests] comments = [ "resolve dependency loop with sqlx", ] run = ["none"] ``` sqlx-sqlite-fix-metadata.diff ``` --- sqlx-sqlite-0.7.4/Cargo.toml 1970-01-01T00:00:01+00:00 +++ sqlx-sqlite-0.7.4/Cargo.toml 2024-07-07T08:40:24.250434+00:00 @@ -29,6 +29,9 @@ [dependencies.chrono] version = "0.4.22" +features = [ + "clock", +] optional = true default-features = false @@ -65,11 +68,8 @@ default-features = false [dependencies.libsqlite3-sys] -version = "0.27.0" +version = "0.28.0" features = [ - "pkg-config", - "vcpkg", - "bundled", "unlock_notify", ] default-features = false ```
Copr build: https://copr.fedorainfracloud.org/coprs/build/7719736 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2279546-rust-sqlx-sqlite/fedora-rawhide-x86_64/07719736-rust-sqlx-sqlite/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
This is an automatic action taken by review-stats script. The ticket reviewer failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we reset the status and the assignee of this ticket.
Spec URL: https://lecris.fedorapeople.org/reviews/rust-sqlx-sqlite/rust-sqlx-sqlite.spec SRPM URL: https://lecris.fedorapeople.org/reviews/rust-sqlx-sqlite/rust-sqlx-sqlite-0.8.1-1.fc42.src.rpm Bump sqlx packages to 0.8.1
Copr build: https://copr.fedorainfracloud.org/coprs/build/7947983 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2279546-rust-sqlx-sqlite/fedora-rawhide-x86_64/07947983-rust-sqlx-sqlite/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://lecris.fedorapeople.org/reviews/rust-sqlx-sqlite/rust-sqlx-sqlite.spec SRPM URL: https://lecris.fedorapeople.org/reviews/rust-sqlx-sqlite/rust-sqlx-sqlite-0.8.2-1.fc42.src.rpm Bumped to 0.8.2
Copr build: https://copr.fedorainfracloud.org/coprs/build/8010408 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2279546-rust-sqlx-sqlite/fedora-rawhide-x86_64/08010408-rust-sqlx-sqlite/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide 🫤 test suite is run and all unit tests pass (disabled with explanation) ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
Thank you for the review, Fabio
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-sqlx-sqlite
FEDORA-2024-256d466a33 (rust-sqlx-sqlite-0.8.2-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2024-256d466a33
FEDORA-2024-256d466a33 (rust-sqlx-sqlite-0.8.2-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.