Bug 2279547
| Summary: | Review Request: rust-sqlx - The Rust SQL Toolkit | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Cristian Le <fedora> | ||||
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | decathorpe, package-review | ||||
| Target Milestone: | --- | Keywords: | AutomationTriaged | ||||
| Target Release: | --- | Flags: | decathorpe:
fedora-review+
|
||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| URL: | https://crates.io/crates/sqlx | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | rust-sqlx-0.8.2-1.fc42 | Doc Type: | If docs needed, set a value | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2024-10-04 09:50:43 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | 2279537, 2279540, 2279542, 2279544, 2279546 | ||||||
| Bug Blocks: | 2297310 | ||||||
| Attachments: |
|
||||||
|
Description
Cristian Le
2024-05-07 12:33:18 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/7424598 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2279547-rust-sqlx/fedora-rawhide-x86_64/07424598-rust-sqlx/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://lecris.fedorapeople.org/reviews/rust-sqlx/rust-sqlx.spec SRPM URL: https://lecris.fedorapeople.org/reviews/rust-sqlx/rust-sqlx-0.8.1-1.fc42.src.rpm Bump sqlx packages to 0.8.1 Copr build: https://copr.fedorainfracloud.org/coprs/build/7947995 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2279547-rust-sqlx/fedora-rawhide-x86_64/07947995-rust-sqlx/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://lecris.fedorapeople.org/reviews/rust-sqlx/rust-sqlx.spec SRPM URL: https://lecris.fedorapeople.org/reviews/rust-sqlx/rust-sqlx-0.8.2-1.fc42.src.rpm Bumped to 0.8.2 Copr build: https://copr.fedorainfracloud.org/coprs/build/8010411 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2279547-rust-sqlx/fedora-rawhide-x86_64/08010411-rust-sqlx/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. > # * can't seem to compile them :/
> %bcond_with check
What is this supposed to mean? Please elaborate in more detail than "meh, no". :)
Other than that, package looks pretty good to me.
Though there are some files that you might want to exclude from the -devel package:
- contrib: VS Code plugin?
- examples/: just a python script that calls sqlx-cli, which is not included in the package?
- gen-changelog.sh: doesn't see useful for packaging
- rust-toolchain.toml: not useful for packaging
- tests/ directory in general: lots of scripts (bash, python), certificates, etc.
> What is this supposed to mean? Please elaborate in more detail than "meh, no". :)
Argh, sorry about that, the main issue is that `sqlx` tests are using the unpublished `sqlx-test` local crate, but I did not check the `docs` tests and those are actually usable, so I will keep those at least. I think I remember having had other issues with the tests when running locally with vendored packages in 0.7.x, so probably I was thinking about that at that time as well.
Spec URL: https://lecris.fedorapeople.org/reviews/rust-sqlx/rust-sqlx.spec SRPM URL: https://lecris.fedorapeople.org/reviews/rust-sqlx/rust-sqlx-0.8.2-1.fc42.src.rpm Run only doc tests and remove auxiliary files Spec URL: https://lecris.fedorapeople.org/reviews/rust-sqlx/rust-sqlx.spec SRPM URL: https://lecris.fedorapeople.org/reviews/rust-sqlx/rust-sqlx-0.8.2-1.fc42.src.rpm Include `lib` tests as well Copr build: https://copr.fedorainfracloud.org/coprs/build/8083953 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2279547-rust-sqlx/fedora-rawhide-x86_64/08083953-rust-sqlx/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Created attachment 2049129 [details]
The .spec file difference from Copr build 8083953 to 8083983
Copr build: https://copr.fedorainfracloud.org/coprs/build/8083983 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2279547-rust-sqlx/fedora-rawhide-x86_64/08083983-rust-sqlx/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Thank you, the package looks good to me now! === Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass (some tests that cannot be run are disabled) ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license files are included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version (*NOT* pre-release) filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) Thank you for the review, Fabio The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-sqlx FEDORA-2024-ccd7ba08b7 (rust-sqlx-0.8.2-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2024-ccd7ba08b7 FEDORA-2024-ccd7ba08b7 (rust-sqlx-0.8.2-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2024-655eddbffb (rust-sqlx-0.8.2-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-655eddbffb FEDORA-2024-b381100094 (rust-sqlx-0.8.2-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-b381100094 FEDORA-2024-59641c4101 has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-59641c4101` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-59641c4101 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-b381100094 has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-b381100094` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-b381100094 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-655eddbffb has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-655eddbffb` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-655eddbffb See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-655eddbffb (rust-sqlx-0.8.2-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2024-59641c4101 (rust-sqlx-0.8.2-1.fc39) has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2024-b381100094 (rust-sqlx-0.8.2-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report. |