Bug 228241
Summary: | Review Request: eb - ebook library | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Jens Petersen <petersen> |
Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | eng-i18n-bugs, moceap, mtasaka |
Target Milestone: | --- | Flags: | gwync:
fedora-cvs+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-02-14 06:07:46 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779, 228243 |
Description
Jens Petersen
2007-02-12 02:17:57 UTC
Mock build is fine. But got rpmlint warnings for main and devel package as W: eb conffile-without-noreplace-flag /etc/eb.conf A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file: %config(noreplace) /etc/your_config_file_here W: eb-devel summary-not-capitalized eb libray development files Summary doesn't begin with a capital letter. Thanks. Should be fixed in: Spec URL: http://people.redhat.com/petersen/extras/eb.spec SRPM URL: http://people.redhat.com/petersen/extras/eb-4.3-2.src.rpm BTW rpmlint now complains for me: E: eb description-line-too-long EB ライブラリは CD-ROM 書籍にアクセスするための C のライブラリです。 But I guess this is based on the length of the utf-8 bytes not the number of characters. Got W: eb incoherent-version-in-changelog 4.3-1 4.3-2.fc7 The last entry in %changelog contains a version identifier that is not coherent with the epoch:version-release tuple of the package. Strange i did not see error you said on my machine. Anyway here comes review Review: + package builds in mock (development i386). + rpmlint is silent for SRPM. - rpmlint is not silent for RPM but its a simple warning that can be solved while importing a package. + source files match upstream. f7aee92355cae7e4c81cf26df4345b07 eb-4.3.tar.bz2 + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. License text included in package. + %doc is small; no -doc subpackage required. + %doc does not affect runtime. + COPYING included in %doc. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no static libraries. + no .pc file present. + -devel subpackage exists + no scriptlets are used. + no .la files. + translations are available + Dose owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. APPROVED. Thanks. :) Added package to CVSSyncNeeded. Package imported to cvs and devel package built. FC6 package built too. Package Change Request ====================== Package Name: eb New Branches: el6 epel7 Owners: moceap petersen Git done (by process-git-requests). |