Bug 228241 - Review Request: eb - ebook library
Review Request: eb - ebook library
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Parag AN(पराग)
Fedora Package Reviews List
:
Depends On:
Blocks: FE-ACCEPT 228243
  Show dependency treegraph
 
Reported: 2007-02-11 21:17 EST by Jens Petersen
Modified: 2014-12-15 08:17 EST (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-02-14 01:07:46 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
limburgher: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Jens Petersen 2007-02-11 21:17:57 EST
Spec URL: http://people.redhat.com/petersen/extras/eb.spec
SRPM URL: http://people.redhat.com/petersen/extras/eb-4.3-1.src.rpm
Description:
Library for accessing Japanese CD-ROM electronic books
in EB, EBG, EBXA, EBXA-C, S-EBXA, and EPWING format.

http://www.sra.co.jp/people/m-kasahr/eb/
Comment 1 Parag AN(पराग) 2007-02-11 23:59:46 EST
Mock build is fine.
But got rpmlint warnings for main and devel package as

W: eb conffile-without-noreplace-flag /etc/eb.conf
A configuration file is stored in your package without the noreplace flag.
A way to resolve this is to put the following in your SPEC file:
%config(noreplace) /etc/your_config_file_here

W: eb-devel summary-not-capitalized eb libray development files
Summary doesn't begin with a capital letter.


Comment 2 Jens Petersen 2007-02-12 03:20:12 EST
Thanks.  Should be fixed in:

Spec URL: http://people.redhat.com/petersen/extras/eb.spec
SRPM URL: http://people.redhat.com/petersen/extras/eb-4.3-2.src.rpm
Comment 3 Jens Petersen 2007-02-12 03:27:40 EST
BTW rpmlint now complains for me:

E: eb description-line-too-long EB ライブラリは CD-ROM 書籍にアクセスするための
C のライブラリです。

But I guess this is based on the length of the utf-8 bytes not the number of
characters.
Comment 4 Parag AN(पराग) 2007-02-12 06:22:45 EST
Got 
W: eb incoherent-version-in-changelog 4.3-1 4.3-2.fc7
The last entry in %changelog contains a version identifier that is not
coherent with the epoch:version-release tuple of the package.

Strange i did not see error you said on my machine.
Comment 5 Parag AN(पराग) 2007-02-12 06:28:38 EST
Anyway here comes review
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM.
- rpmlint is not silent for RPM but its a simple warning that can be solved
while importing a package.
+ source files match upstream.
f7aee92355cae7e4c81cf26df4345b07  eb-4.3.tar.bz2
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.  License text included in package.
+ %doc is small; no -doc subpackage required.
+ %doc does not affect runtime.
+ COPYING included in %doc.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no static libraries.
+ no .pc file present.
+ -devel subpackage exists
+ no scriptlets are used.
+ no .la files.
+ translations are available
+ Dose owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.

APPROVED.
Comment 6 Jens Petersen 2007-02-13 01:51:04 EST
Thanks. :)  Added package to CVSSyncNeeded. 
Comment 7 Jens Petersen 2007-02-13 20:00:05 EST
Package imported to cvs and devel package built.
Comment 8 Jens Petersen 2007-02-14 01:07:46 EST
FC6 package built too.
Comment 9 Mosaab Alzoubi 2014-12-14 14:06:15 EST
Package Change Request
======================
Package Name: eb
New Branches: el6 epel7
Owners: moceap petersen
Comment 10 Gwyn Ciesla 2014-12-15 08:17:22 EST
Git done (by process-git-requests).

Note You need to log in before you can comment on or make changes to this bug.