Bug 2283679
| Summary: | Review Request: rust-quanta - High-speed timing library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Cristian Le <fedora> |
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | decathorpe, package-review, pemensik |
| Target Milestone: | --- | Keywords: | AutomationTriaged |
| Target Release: | --- | Flags: | decathorpe:
fedora-review+
|
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://crates.io/crates/quanta | ||
| Whiteboard: | |||
| Fixed In Version: | rust-quanta-0.12.3-1.fc42 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2024-09-12 17:26:46 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 2283684, 2283685 | ||
| Bug Blocks: | 2277964, 2283677, 2283678, 2302678 | ||
|
Description
Cristian Le
2024-05-28 19:43:49 UTC
Spec URL: https://github.com/LecrisUT/rust-metris-rpmspec/raw/83dda26784f2c9cbe603473e461adaec238ddb34/rust-quanta/rust-quanta.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/packit/LecrisUT-rust-metris-rpmspec-main/fedora-rawhide-x86_64/07711187-rust-quanta/rust-quanta-0.12.3-1.fc41.src.rpm rust2rpm.toml ```toml [requires] build = [ "tomcli", ] [scripts.prep] post = [ "# Do not depend on criterion; it is needed only for benchmarks.", "tomcli set Cargo.toml del dev-dependencies.criterion", ] [package] cargo-toml-patch-comments = [ "- Bump average dependency", ] [tests] skip = [ "instant::tests::test_recent", ] comments = [ "Flaky test" ] ``` quanta-fix-metadata.diff ``` --- quanta-0.12.3/Cargo.toml 1970-01-01T00:00:01+00:00 +++ quanta-0.12.3/Cargo.toml 2024-07-05T12:30:39.721330+00:00 @@ -53,7 +53,7 @@ default-features = false [dev-dependencies.average] -version = "0.14" +version = "0.15" [dev-dependencies.criterion] version = "=0.3.3" ``` Copr build: https://copr.fedorainfracloud.org/coprs/build/7712630 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2283679-rust-quanta/fedora-rawhide-x86_64/07712630-rust-quanta/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Copr build: https://copr.fedorainfracloud.org/coprs/build/7712857 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2283679-rust-quanta/fedora-rawhide-x86_64/07712857-rust-quanta/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Fixed some additional dependencies --- Spec URL: https://github.com/LecrisUT/rust-metris-rpmspec/raw/2fb7b40a6528b380d0cbf973a7f10276b2cf2ddc/rust-quanta/rust-quanta.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/packit/LecrisUT-rust-metris-rpmspec-main/fedora-rawhide-x86_64/07716587-rust-quanta/rust-quanta-0.12.3-1.fc41.src.rpm rust2rpm.toml ```toml [features] enable = [ "default", "prost", ] [requires] build = [ "tomcli", ] [scripts.prep] post = [ "# Do not depend on criterion; it is needed only for benchmarks.", "tomcli set Cargo.toml del dev-dependencies.criterion", ] [package] cargo-toml-patch-comments = [ "- Bump average dependency", "- Bump prost-types dependency", "- Remove flaky_tests from default feature", ] [tests] skip = [ "instant::tests::test_recent", ] comments = [ "More flaky tests" ] ``` quanta-fix-metadata.diff ``` --- quanta-0.12.3/Cargo.toml 1970-01-01T00:00:01+00:00 +++ quanta-0.12.3/Cargo.toml 2024-07-08T09:35:19.402094+00:00 @@ -48,18 +48,18 @@ version = "1.4" [dependencies.prost-types] -version = "0.11" +version = "0.12" optional = true default-features = false [dev-dependencies.average] -version = "0.14" +version = "0.15" [dev-dependencies.criterion] version = "=0.3.3" [features] -default = ["flaky_tests"] +default = [] flaky_tests = [] prost = ["prost-types"] ``` Spec URL: https://lecris.fedorapeople.org/reviews/rust-quanta/rust-quanta.spec SRPM URL: https://lecris.fedorapeople.org/reviews/rust-quanta/rust-quanta-0.12.3-1.fc40.src.rpm Update to persistent link [fedora-review-service-build] Spec URL: https://lecris.fedorapeople.org/reviews/rust-quanta/rust-quanta.spec SRPM URL: https://lecris.fedorapeople.org/reviews/rust-quanta/rust-quanta-0.12.3-1.fc42.src.rpm Bump patch for prost 0.13 Copr build: https://copr.fedorainfracloud.org/coprs/build/7947948 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2283679-rust-quanta/fedora-rawhide-x86_64/07947948-rust-quanta/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Some suggestions for improvements: - submit PR to bump prost* from 0.11 to 0.13 upstream - exclude some extraneous files from being installed (Cross.toml, release.toml, rust-toolchain.toml) === Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass (some tests disabled with explanation) ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) > submit PR to bump prost* from 0.11 to 0.13 upstream They already have it from dependabot, but haven't responded to it in a year. Guess I can ping them about it. > exclude some extraneous files from being installed (Cross.toml, release.toml, rust-toolchain.toml) Iirc last time I did that by adding a `scripts.install.pre` to `rm` those files? Thank you for the review, Fabio The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-quanta FEDORA-2024-4e8e2736b6 (rust-quanta-0.12.3-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2024-4e8e2736b6 FEDORA-2024-4e8e2736b6 (rust-quanta-0.12.3-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2024-a66aee315d (rust-quanta-0.12.3-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-a66aee315d FEDORA-2024-4c3e716b20 (rust-quanta-0.12.3-1.fc39) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-4c3e716b20 FEDORA-2024-9ffba44e1e (rust-quanta-0.12.3-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-9ffba44e1e FEDORA-2024-4c3e716b20 has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-4c3e716b20` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-4c3e716b20 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-a66aee315d has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-a66aee315d` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-a66aee315d See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-9ffba44e1e has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-9ffba44e1e` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-9ffba44e1e See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-4c3e716b20 (rust-quanta-0.12.3-1.fc39) has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2024-a66aee315d (rust-quanta-0.12.3-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2024-9ffba44e1e (rust-quanta-0.12.3-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report. |