Bug 2290308
| Summary: | Review Request: rust-cached - Generic cache implementations and simplified function memoization | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Davide Cavalca <davide> |
| Component: | Package Review | Assignee: | Michel Lind <michel> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | dmellado, michel, package-review |
| Target Milestone: | --- | Flags: | michel:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | https://crates.io/crates/cached | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2024-07-30 21:00:32 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 2283589, 2283591, 2283598, 2284641, 2299310 | ||
| Bug Blocks: | |||
|
Description
Davide Cavalca
2024-06-03 23:13:32 UTC
$ cat rust2rpm.toml [scripts] prep.pre = [ # Drop broken example that fails to build # error[E0433]: failed to resolve: could not find `DiskCache` in `cached` "rm examples/disk.rs" ] [features] hide = [ "redis_async_std", "wasm", ] Previous review: https://bugzilla.redhat.com/show_bug.cgi?id=2259225 Copr build: https://copr.fedorainfracloud.org/coprs/build/7526638 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2290308-rust-cached/fedora-rawhide-x86_64/07526638-rust-cached/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://dcavalca.fedorapeople.org/review/rust-cached/rust-cached.spec SRPM URL: https://dcavalca.fedorapeople.org/review/rust-cached/rust-cached-0.53.1-1.fc41.src.rpm Changelog: - update to 0.53.1 $ cat rust2rpm.toml [scripts] prep.pre = [ # Drop broken example that fails to build # error[E0433]: failed to resolve: could not find `DiskCache` in `cached` "rm examples/disk.rs" ] Copr build: https://copr.fedorainfracloud.org/coprs/build/7777604 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2290308-rust-cached/fedora-rawhide-x86_64/07777604-rust-cached/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Still fails to build Problem: nothing provides requested (crate(web-time/default) >= 1.1.0 with crate(web-time/default) < 2.0.0~) Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (MIT) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks (use `fedora-sig-onboard onboard rust-$crate` to automate): - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) ## Review template (compat) Compat package, looks identical to the existing rust-$crate. APPROVED === Recommended post-import rust-sig tasks (use `fedora-sig-onboard onboard -R rust-$crate$ver` to automate): - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-cached FEDORA-2024-6b9bb777cc (rust-cached-0.53.1-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-6b9bb777cc FEDORA-2024-6b9bb777cc (rust-cached-0.53.1-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report. *** Bug 2259225 has been marked as a duplicate of this bug. *** |