Bug 2290308 - Review Request: rust-cached - Generic cache implementations and simplified function memoization
Summary: Review Request: rust-cached - Generic cache implementations and simplified fu...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Michel Lind
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/cached
Whiteboard:
: 2259225 (view as bug list)
Depends On: 2283589 2283591 2283598 2284641 2299310
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-06-03 23:13 UTC by Davide Cavalca
Modified: 2024-10-13 20:15 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-07-30 21:00:32 UTC
Type: ---
Embargoed:
michel: fedora-review+


Attachments (Terms of Use)

Description Davide Cavalca 2024-06-03 23:13:32 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-cached/rust-cached.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-cached/rust-cached-0.51.3-1.fc41.src.rpm

Description:
Generic cache implementations and simplified function memoization.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2024-06-03 23:14:18 UTC
$ cat rust2rpm.toml 
[scripts]
prep.pre = [
  # Drop broken example that fails to build
  # error[E0433]: failed to resolve: could not find `DiskCache` in `cached`
  "rm examples/disk.rs"
]

[features]
hide = [
  "redis_async_std",
  "wasm",
]

Comment 2 Davide Cavalca 2024-06-03 23:14:35 UTC
Previous review: https://bugzilla.redhat.com/show_bug.cgi?id=2259225

Comment 3 Fedora Review Service 2024-06-03 23:19:59 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7526638
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2290308-rust-cached/fedora-rawhide-x86_64/07526638-rust-cached/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 5 Davide Cavalca 2024-07-23 16:41:04 UTC
$ cat rust2rpm.toml
[scripts]
prep.pre = [
  # Drop broken example that fails to build
  # error[E0433]: failed to resolve: could not find `DiskCache` in `cached`
  "rm examples/disk.rs"
]

Comment 6 Fedora Review Service 2024-07-23 16:44:28 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7777604
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2290308-rust-cached/fedora-rawhide-x86_64/07777604-rust-cached/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 7 Michel Lind 2024-07-29 20:14:31 UTC
Still fails to build

Problem: nothing provides requested (crate(web-time/default) >= 1.1.0 with crate(web-time/default) < 2.0.0~)

Comment 8 Michel Lind 2024-07-30 17:56:04 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks (use `fedora-sig-onboard onboard rust-$crate` to automate):

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

## Review template (compat)

Compat package, looks identical to the existing rust-$crate. APPROVED

===

Recommended post-import rust-sig tasks (use `fedora-sig-onboard onboard -R rust-$crate$ver` to automate):

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 9 Fedora Admin user for bugzilla script actions 2024-07-30 17:57:22 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-cached

Comment 10 Fedora Update System 2024-07-30 20:58:14 UTC
FEDORA-2024-6b9bb777cc (rust-cached-0.53.1-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-6b9bb777cc

Comment 11 Fedora Update System 2024-07-30 21:00:32 UTC
FEDORA-2024-6b9bb777cc (rust-cached-0.53.1-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 12 Fabio Valentini 2024-10-13 20:15:27 UTC
*** Bug 2259225 has been marked as a duplicate of this bug. ***


Note You need to log in before you can comment on or make changes to this bug.