Bug 2299310 - Review Request: rust-web-time - Drop-in replacement for std::time for Wasm in browsers
Summary: Review Request: rust-web-time - Drop-in replacement for std::time for Wasm in...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Michel Lind
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2299309
Blocks: 2290308
TreeView+ depends on / blocked
 
Reported: 2024-07-22 15:08 UTC by Davide Cavalca
Modified: 2024-07-30 17:30 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-07-30 17:30:33 UTC
Type: ---
Embargoed:
michel: fedora-review+


Attachments (Terms of Use)

Description Davide Cavalca 2024-07-22 15:08:40 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-web-time/rust-web-time.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-web-time/rust-web-time-1.1.0-1.fc41.src.rpm

Description:
Drop-in replacement for std::time for Wasm in browsers.

Fedora Account System Username: dcavalca

Comment 1 Fabio Valentini 2024-07-23 12:54:57 UTC
Unless you plan to package something as a WASM module, this dependency should really not be needed.

Comment 2 Davide Cavalca 2024-07-23 15:20:48 UTC
So this came up as I was updating cached in https://bugzilla.redhat.com/show_bug.cgi?id=2290308 and noticed upstream picked up the dependency. It was added in https://github.com/jaemk/cached/pull/214 which says it's indeed only used with wasm, but I didn't see a clean way to excise it.

Comment 3 Fabio Valentini 2024-07-23 15:23:47 UTC
Ah. So it's not a *replacement*, but a *wrapper* that acts as a polyfill on WASM and re-exports Instant from std on non-WASM. That's kind of an unfortunate design choice :(

Comment 4 Michel Lind 2024-07-29 20:29:31 UTC
Please provide a comment in the spec about the content of web-time-fix-metadata.diff

Comment 6 Davide Cavalca 2024-07-30 03:47:34 UTC
$ cat rust2rpm.toml 
[package]
cargo-toml-patch-comments = ["Drop unused benchmark example"]

Comment 7 Michel Lind 2024-07-30 15:38:39 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks (use `fedora-sig-onboard onboard rust-$crate` to automate):

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

## Review template (compat)

Compat package, looks identical to the existing rust-$crate. APPROVED

===

Recommended post-import rust-sig tasks (use `fedora-sig-onboard onboard -R rust-$crate$ver` to automate):

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 8 Fedora Admin user for bugzilla script actions 2024-07-30 15:40:05 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-web-time

Comment 9 Fedora Update System 2024-07-30 17:28:02 UTC
FEDORA-2024-2b928ac9c4 (rust-web-time-1.1.0-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-2b928ac9c4

Comment 10 Fedora Update System 2024-07-30 17:30:33 UTC
FEDORA-2024-2b928ac9c4 (rust-web-time-1.1.0-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.