Bug 2290480

$ cat rust2rpm.toml 
[package]
summary = "Know how happy your systemd is"
description = "monitord is a library and daemon to gather statistics about systemd."
cargo-toml-patch-comments = [
  "bump int_enum to 1.1",
  "bump struct-field-names-as-array to 0.3",
]
extra-patches = [
  { number = 2, file = "monitord-struct-field-names-as-array-0.3.patch", comments = ["https://github.com/cooperlees/monitord/commit/37d0c20c70512bead7f840c39f7c004a1582d12f"] },
  { number = 3, file = "monitord-int-enum-1.1.patch", comments = ["https://github.com/cooperlees/monitord/commit/391398a95e12caffa745bdd2acab3c111d2477cc"] },
]
extra-files = [
  "%config(noreplace) %{_sysconfdir}/monitord.conf",
]

[scripts]
prep.pre = [
  # Drop prebuilt docs
  "rm -r docs",
]
install.post = [
  "install -Dpm0644 -t %{buildroot}%{_sysconfdir} monitord.conf",
]

Copr build:
https://copr.fedorainfracloud.org/coprs/build/7530279
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2290480-rust-monitord/fedora-rawhide-x86_64/07530279-rust-monitord/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Spec URL: https://dcavalca.fedorapeople.org/review/rust-monitord/rust-monitord.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-monitord/rust-monitord-0.8.4-1.fc41.src.rpm

Changelog:
- update to 0.8.4

$ cat rust2rpm.toml 
[package]
summary = "Know how happy your systemd is"
description = "monitord is a library and daemon to gather statistics about systemd."
extra-files = [
  "%config(noreplace) %{_sysconfdir}/monitord.conf",
]

[scripts]
prep.pre = [
  # Drop prebuilt docs
  "rm -r docs",
]
install.post = [
  "install -Dpm0644 -t %{buildroot}%{_sysconfdir} monitord.conf",
]

Created attachment 2036570 [details]
The .spec file difference from Copr build 7530279 to 7543772

Copr build:
https://copr.fedorainfracloud.org/coprs/build/7543772
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2290480-rust-monitord/fedora-rawhide-x86_64/07543772-rust-monitord/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[fedora-review-service-build]

Did you forget to package rust-struct-field-names-as-array?

rust-struct-field-names-as-array-derive exists but not the crate that's using it

Problem: nothing provides requested (crate(struct-field-names-as-array/default) >= 0.3.0 with crate(struct-field-names-as-array/default) < 0.4.0~)

rust-struct-field-names-as-array should be in Rawhide now.

Waiting for upstream to clarify a license discrepancy - Cargo.toml says GPL-2.0-or-later but LICENSE file is for LGPL 2.1(+)

Spec URL: https://dcavalca.fedorapeople.org/review/rust-monitord/rust-monitord.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-monitord/rust-monitord-0.8.3-1.fc41.src.rpm

Changelog:
- backport upstream commit to fix the license

$ cat rust2rpm.toml 
[package]
summary = "Know how happy your systemd is"
description = "monitord is a library and daemon to gather statistics about systemd."
extra-files = [
  "%config(noreplace) %{_sysconfdir}/monitord.conf",
]
extra-patches = [
  { "number" = 2, "file" = "https://github.com/cooperlees/monitord/commit/8ced4d5c5fe507cd583e6518d88ae6e2b5a45cec.patch", "comments" = ["Switch license file from LGPL 2.1 to GPL 2"] },
]

[scripts]
prep.pre = [
  # Drop prebuilt docs
  "rm -r docs",
]
install.post = [
  "install -Dpm0644 -t %{buildroot}%{_sysconfdir} monitord.conf",
]

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (GPL-2.0-only) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks (use `fedora-sig-onboard onboard rust-$crate` to automate):

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-monitord

FEDORA-2024-7d7e7af423 (rust-monitord-0.8.3-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-7d7e7af423

FEDORA-2024-7d7e7af423 (rust-monitord-0.8.3-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2024-e117ad28ae (rust-monitord-0.8.4-1.fc40 and rust-monitord-exporter-0.3.0-1.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-e117ad28ae

FEDORA-2024-fd9e2e77f1 (rust-monitord-0.8.4-1.fc39 and rust-monitord-exporter-0.3.0-1.fc39) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-fd9e2e77f1

FEDORA-2024-e117ad28ae has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-e117ad28ae \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-e117ad28ae

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2024-fd9e2e77f1 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-fd9e2e77f1 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-fd9e2e77f1

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2024-fd9e2e77f1 (rust-monitord-0.8.4-1.fc39 and rust-monitord-exporter-0.3.0-1.fc39) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2024-e117ad28ae (rust-monitord-0.8.4-1.fc40 and rust-monitord-exporter-0.3.0-1.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.