Bug 2290730 - Review Request: rust-monitord-exporter - Let Prometheus know how happy your systemd is
Summary: Review Request: rust-monitord-exporter - Let Prometheus know how happy your s...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Michel Lind
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/monitord-exp...
Whiteboard:
Depends On: 2284045 2290480
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-06-06 15:22 UTC by Davide Cavalca
Modified: 2024-08-02 05:50 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-07-23 23:43:03 UTC
Type: ---
Embargoed:
michel: fedora-review+


Attachments (Terms of Use)

Description Davide Cavalca 2024-06-06 15:22:10 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-monitord-exporter/rust-monitord-exporter.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-monitord-exporter/rust-monitord-exporter-0.3.0-1.fc41.src.rpm

Description:
monitord-exporter is a Prometheus exporter using monitord to export statistic to Prometheus collectors.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2024-06-06 15:22:37 UTC
$ cat rust2rpm.toml 
[package]
summary = "Let Prometheus know how happy your systemd is"
description = "monitord-exporter is a Prometheus exporter using monitord to export statistic to Prometheus collectors."
extra-files = [
  "%{_unitdir}/monitord-exporter.service",
]

[scripts]
install.post = [
  "install -Dpm0644 -t %{buildroot}%{_unitdir} monitord-exporter.service",
]

[requires]
build = ["systemd-rpm-macros"]

Comment 2 Fedora Review Service 2024-06-06 15:43:33 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7543785
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2290730-rust-monitord-exporter/fedora-rawhide-x86_64/07543785-rust-monitord-exporter/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Fedora Review Service 2024-07-23 16:17:28 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7777554
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2290730-rust-monitord-exporter/fedora-rawhide-x86_64/07777554-rust-monitord-exporter/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 5 Michel Lind 2024-07-23 23:26:43 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (GPL-2.0-or-later) and is acceptable for Fedora
- licenses of statically linked dependencies are correctly taken into account
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks (use `fedora-sig-onboard onboard rust-$crate` to automate):

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 6 Fedora Admin user for bugzilla script actions 2024-07-23 23:27:37 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-monitord-exporter

Comment 7 Fedora Update System 2024-07-23 23:39:46 UTC
FEDORA-2024-d7c99cf1f9 (rust-monitord-exporter-0.3.0-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-d7c99cf1f9

Comment 8 Fedora Update System 2024-07-23 23:43:03 UTC
FEDORA-2024-d7c99cf1f9 (rust-monitord-exporter-0.3.0-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 9 Fedora Update System 2024-07-24 00:21:28 UTC
FEDORA-2024-e117ad28ae (rust-monitord-0.8.4-1.fc40 and rust-monitord-exporter-0.3.0-1.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-e117ad28ae

Comment 10 Fedora Update System 2024-07-24 00:56:26 UTC
FEDORA-2024-fd9e2e77f1 (rust-monitord-0.8.4-1.fc39 and rust-monitord-exporter-0.3.0-1.fc39) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-fd9e2e77f1

Comment 11 Fedora Update System 2024-07-25 01:52:46 UTC
FEDORA-2024-e117ad28ae has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-e117ad28ae \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-e117ad28ae

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2024-07-25 02:41:18 UTC
FEDORA-2024-fd9e2e77f1 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-fd9e2e77f1 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-fd9e2e77f1

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2024-08-02 03:49:11 UTC
FEDORA-2024-fd9e2e77f1 (rust-monitord-0.8.4-1.fc39 and rust-monitord-exporter-0.3.0-1.fc39) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 14 Fedora Update System 2024-08-02 05:50:56 UTC
FEDORA-2024-e117ad28ae (rust-monitord-0.8.4-1.fc40 and rust-monitord-exporter-0.3.0-1.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.