Bug 2295792
| Summary: | Review Request: retis - Tracing packets in the Linux networking stack | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Antoine Tenart <atenart> | ||||
| Component: | Package Review | Assignee: | Fernando F. Mancera <ferferna> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | amorenoz, ferferna, package-review, pvalerio | ||||
| Target Milestone: | --- | Keywords: | AutomationTriaged | ||||
| Target Release: | --- | Flags: | ferferna:
fedora-review+
|
||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| URL: | https://github.com/retis-org/retis | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2025-04-09 10:10:03 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | 2260404, 2295793, 2295799, 2295815 | ||||||
| Bug Blocks: | 177841 | ||||||
| Attachments: |
|
||||||
|
Description
Antoine Tenart
2024-07-04 13:37:27 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/7707867 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2295792-retis/fedora-rawhide-x86_64/07707867-retis/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Blocked FE-NEEDSPONSOR as you mention still requiring a sponsor Ref: https://docs.fedoraproject.org/en-US/package-maintainers/Package_Review_Process/#_contributor (bullet #3) All prerequisites are now done, which means we can now tackle the Retis inclusion itself. Finally! The spec file was updated and 4 out of tree patches were added. A description for each of them is given in the spec file. Those were manually generated as we don't use rust2rpm here. Spec URL: https://github.com/retis-org/copr-playground/blob/0d8659d2dd075155611c7ab9b893fb82e0759eb0/retis.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/@retis/playground/fedora-rawhide-x86_64/08801956-retis/retis-1.5.2-0.fc43.src.rpm Build: https://copr.fedorainfracloud.org/coprs/g/retis/playground/build/8801956/ Thanks! Copr build: https://copr.fedorainfracloud.org/coprs/build/8802030 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2295792-retis/fedora-rawhide-x86_64/08802030-retis/fedora-review/review.txt Found issues: - Not a valid SPDX expression 'GPLv2'. It seems that you are using the old Fedora license abbreviations. Try `license-fedora2spdx' for converting it to SPDX. Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Fixed the SPDX license in the spec file. Spec URL: https://github.com/retis-org/copr-playground/blob/2f4433edbab65a95543b59f5e3a21150621989dc/retis.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/@retis/playground/fedora-rawhide-x86_64/08802186-retis/retis-1.5.2-0.fc43.src.rpm Build: https://copr.fedorainfracloud.org/coprs/g/retis/playground/build/8802186/ Created attachment 2081264 [details]
The .spec file difference from Copr build 8802030 to 8802233
Copr build: https://copr.fedorainfracloud.org/coprs/build/8802233 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2295792-retis/fedora-rawhide-x86_64/08802233-retis/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Hey there! I have been reviewing this package. These are my findings: [X] Builds in Fedora rawhide and Fedora 42 [X] License matches upstream specification and is acceptable for Fedora [X] License is installed properly [X] Test are passing [X] Latest version is packaged Notes: There are some rpmlint warnings but I think the most relevant one is: - retis.x86_64: W: no-manual-page-for-binary retis Please, consider adding a manual page in the future. Result: APPROVED! The Pagure repository was created at https://src.fedoraproject.org/rpms/retis FEDORA-2025-258f476ae7 (retis-1.5.2-0.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-258f476ae7 FEDORA-2025-258f476ae7 (retis-1.5.2-0.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report. |