Bug 2295799 - Review Request: rust-pnet_packet - Cross-platform, binary packet parsing and manipulation
Summary: Review Request: rust-pnet_packet - Cross-platform, binary packet parsing and ...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fernando F. Mancera
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/pnet_packet
Whiteboard:
Depends On: 2295801 2295802
Blocks: FE-NEEDSPONSOR 2295792
TreeView+ depends on / blocked
 
Reported: 2024-07-04 13:55 UTC by Adrián Moreno
Modified: 2024-12-19 16:07 UTC (History)
5 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-12-19 16:07:52 UTC
Type: ---
Embargoed:
ferferna: fedora-review+


Attachments (Terms of Use)

Description Adrián Moreno 2024-07-04 13:55:46 UTC
Spec URL: https://raw.githubusercontent.com/retis-org/copr-playground/main/rust-pnet_packet.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/%40retis/playground/fedora-rawhide-x86_64/07671885-rust-pnet_packet/rust-pnet_packet-0.34.0-1.fc41.src.rpm
Build: https://copr.fedorainfracloud.org/coprs/g/retis/playground/build/7671885/

Description:

Cross-platform, binary packet parsing and manipulation. It is part of the libpnet project that provides cross-platform API for low level networking in Rust.

Fedora Account System Usernames: atenart, pvaler, amorenoz

Notes:
Other components of the libpnet project, such as rust-pnet_datalink (https://packages.fedoraproject.org/pkgs/rust-pnet_datalink/) are already packaged in Fedora.

Comment 1 Fedora Review Service 2024-07-04 13:57:41 UTC
Cannot find any valid SRPM URL for this ticket. Common causes are:

- You didn't specify `SRPM URL: ...` in the ticket description
  or any of your comments
- The URL schema isn't HTTP or HTTPS
- The SRPM package linked in your URL doesn't match the package name specified
  in the ticket summary


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Paul Pfeister 2024-07-06 22:19:32 UTC
Blocked FE-NEEDSPONSOR as you mention still requiring a sponsor

Comment 3 Adrián Moreno 2024-11-26 11:39:00 UTC
Dependency (https://bugzilla.redhat.com/show_bug.cgi?id=2295801) is already part of Fedora, retriggering.

Comment 4 Adrián Moreno 2024-11-26 11:39:43 UTC
[fedora-review-service-build]

Comment 5 Fedora Review Service 2024-11-26 11:46:16 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8315096
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2295799-rust-pnet_packet/fedora-rawhide-x86_64/08315096-rust-pnet_packet/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 7 Fedora Review Service 2024-12-03 14:17:53 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8337785
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2295799-rust-pnet_packet/fedora-rawhide-x86_64/08337785-rust-pnet_packet/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 8 Fabio Valentini 2024-12-08 17:19:37 UTC
Fernando, do you plan to review this package (you assigned this one to yourself, but didn't change the bug status to ASSIGNED)?
All dependencies should be available now. If you don't have time, I would be happy to take over.

Comment 9 Fernando F. Mancera 2024-12-18 14:10:04 UTC
I noticed you are packaging 0.34.0 instead of the latest version 0.35.0, as 0.35.0 was released on May 2024, could you update it to 0.35.0?

Thank you!

Comment 10 Fabio Valentini 2024-12-18 14:13:21 UTC
(In reply to Fernando F. Mancera from comment #9)
> I noticed you are packaging 0.34.0 instead of the latest version 0.35.0, as
> 0.35.0 was released on May 2024, could you update it to 0.35.0?
> 
> Thank you!

This is likely not possible -- all other packages for pnet_* crates in Fedora are currently at v0.34, and this one would need to match.

Comment 11 Fernando F. Mancera 2024-12-18 14:46:55 UTC
Ah good point, that is true. It happened the same with the other pnet_ package. Thanks Fabio!

Comment 12 Fernando F. Mancera 2024-12-19 10:34:33 UTC
Specfile was generated using rust2rpm.

Check list for rust package:

[X] package contains only permissible content
[X] package builds and installs without errors on rawhide
[X] test suite is run and all unit tests pass
[X] latest version of the crate is packaged
[X] license matches upstream specification and is acceptable for Fedora
[X] license file is included with %license in %files
[X] package complies with Rust Packaging Guidelines

Package APPROVED!

Please note that the package doesn't build in F41 or F40 but that is fine.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

===

Comment 13 Fedora Admin user for bugzilla script actions 2024-12-19 15:43:57 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-pnet_packet

Comment 14 Fedora Update System 2024-12-19 16:05:38 UTC
FEDORA-2024-1c35ed84cc (rust-pnet_packet-0.34.0-1.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-1c35ed84cc

Comment 15 Fedora Update System 2024-12-19 16:07:52 UTC
FEDORA-2024-1c35ed84cc (rust-pnet_packet-0.34.0-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.