Bug 2297082
| Summary: | Review Request: rust-endian-num - Byte-order-aware numeric types | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Oliver Steffen <osteffen> |
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | berrange, crobinso, decathorpe, kraxel, osteffen, package-review |
| Target Milestone: | --- | Keywords: | AutomationTriaged |
| Target Release: | --- | Flags: | decathorpe:
fedora-review+
|
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://crates.io/crates/endian-num | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2024-07-17 10:48:29 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Oliver Steffen
2024-07-10 12:53:16 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/7722534 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2297082-rust-endian-num/fedora-rawhide-x86_64/07722534-rust-endian-num/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Do you do review swaps and would you be interested in https://bugzilla.redhat.com/show_bug.cgi?id=2296168 ? You might want to %exclude the Dockerfile and rustfmt.toml config file from the -devel package since they're extraneous and not used during package builds. But that's not a prerequisite for approval, so ... === Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-endian-num (In reply to Fabio Valentini from comment #3) > You might want to %exclude the Dockerfile and rustfmt.toml config file from > the -devel package since they're extraneous and not used during package > builds. But that's not a prerequisite for approval, so ... > Done. Thanks! Unit tests during package build are failing on i686 due to upstream bug in some test cases (conversion of 64bit literals). See: https://koji.fedoraproject.org/koji/taskinfo?taskID=120613279 I reported it upstream: https://github.com/rust-osdev/endian-num/issues/3 What to do now until this is fixed? FEDORA-2024-5d98a2929b (rust-endian-num-0.1.1-2.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-5d98a2929b FEDORA-2024-5d98a2929b (rust-endian-num-0.1.1-2.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report. |