Bug 2297082 - Review Request: rust-endian-num - Byte-order-aware numeric types
Summary: Review Request: rust-endian-num - Byte-order-aware numeric types
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/endian-num
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-07-10 12:53 UTC by Oliver Steffen
Modified: 2024-07-17 10:48 UTC (History)
6 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-07-17 10:48:29 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Oliver Steffen 2024-07-10 12:53:16 UTC
Spec URL: https://osteffen.fedorapeople.org/packages/rust-endian-num/rust-endian-num.spec
SRPM URL: https://osteffen.fedorapeople.org/packages/rust-endian-num/rust-endian-num-0.1.1-1.fc41.src.rpm
Description: Byte-order-aware numeric types
Fedora Account System Username: osteffen

This crate is packaged directly from crates.io.

It is needed as a dependency for rust-bitfield-struct-0.7.0 (https://bugzilla.redhat.com/show_bug.cgi?id=2290696)

This is part of the effort to add the Coconut-SVSM paravisor to Fedora.
It would enables Fedora virtualization hosts to launch confidential
virtual machines using AMD's SEV-SNP technology.
See https://fedoraproject.org/wiki/Changes/ConfidentialVirtHostAMDSEVSNP

Comment 1 Fedora Review Service 2024-07-10 13:30:34 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7722534
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2297082-rust-endian-num/fedora-rawhide-x86_64/07722534-rust-endian-num/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 wojnilowicz 2024-07-10 16:58:01 UTC
Do you do review swaps and would you be interested in https://bugzilla.redhat.com/show_bug.cgi?id=2296168 ?

Comment 3 Fabio Valentini 2024-07-14 16:45:02 UTC
You might want to %exclude the Dockerfile and rustfmt.toml config file from the -devel package since they're extraneous and not used during package builds. But that's not a prerequisite for approval, so ...

===

Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 4 Fedora Admin user for bugzilla script actions 2024-07-17 07:36:04 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-endian-num

Comment 5 Oliver Steffen 2024-07-17 07:57:54 UTC
(In reply to Fabio Valentini from comment #3)
> You might want to %exclude the Dockerfile and rustfmt.toml config file from
> the -devel package since they're extraneous and not used during package
> builds. But that's not a prerequisite for approval, so ...
>
Done. Thanks!

Comment 6 Oliver Steffen 2024-07-17 08:30:02 UTC
Unit tests during package build are failing on i686 due to upstream bug in some test cases (conversion of 64bit literals).
See:  https://koji.fedoraproject.org/koji/taskinfo?taskID=120613279

I reported it upstream: https://github.com/rust-osdev/endian-num/issues/3

What to do now until this is fixed?

Comment 7 Fedora Update System 2024-07-17 10:44:56 UTC
FEDORA-2024-5d98a2929b (rust-endian-num-0.1.1-2.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-5d98a2929b

Comment 8 Fedora Update System 2024-07-17 10:48:29 UTC
FEDORA-2024-5d98a2929b (rust-endian-num-0.1.1-2.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.