Bug 2299310
| Summary: | Review Request: rust-web-time - Drop-in replacement for std::time for Wasm in browsers | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Davide Cavalca <davide> |
| Component: | Package Review | Assignee: | Michel Lind <michel> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | decathorpe, michel, package-review |
| Target Milestone: | --- | Flags: | michel:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2024-07-30 17:30:33 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 2299309 | ||
| Bug Blocks: | 2290308 | ||
|
Description
Davide Cavalca
2024-07-22 15:08:40 UTC
Unless you plan to package something as a WASM module, this dependency should really not be needed. So this came up as I was updating cached in https://bugzilla.redhat.com/show_bug.cgi?id=2290308 and noticed upstream picked up the dependency. It was added in https://github.com/jaemk/cached/pull/214 which says it's indeed only used with wasm, but I didn't see a clean way to excise it. Ah. So it's not a *replacement*, but a *wrapper* that acts as a polyfill on WASM and re-exports Instant from std on non-WASM. That's kind of an unfortunate design choice :( Please provide a comment in the spec about the content of web-time-fix-metadata.diff Spec URL: https://dcavalca.fedorapeople.org/review/rust-web-time/rust-web-time.spec SRPM URL: https://dcavalca.fedorapeople.org/review/rust-web-time/rust-web-time-1.1.0-1.fc41.src.rpm Changelog: - add comment for patch $ cat rust2rpm.toml [package] cargo-toml-patch-comments = ["Drop unused benchmark example"] Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks (use `fedora-sig-onboard onboard rust-$crate` to automate): - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) ## Review template (compat) Compat package, looks identical to the existing rust-$crate. APPROVED === Recommended post-import rust-sig tasks (use `fedora-sig-onboard onboard -R rust-$crate$ver` to automate): - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-web-time FEDORA-2024-2b928ac9c4 (rust-web-time-1.1.0-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-2b928ac9c4 FEDORA-2024-2b928ac9c4 (rust-web-time-1.1.0-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report. |