Bug 2309192
| Summary: | Review Request: rust-derive_more-impl - Internal implementation of derive_more crate | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabio Valentini <decathorpe> |
| Component: | Package Review | Assignee: | wojnilowicz <lukasz.wojnilowicz> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | lukasz.wojnilowicz, package-review |
| Target Milestone: | --- | Flags: | lukasz.wojnilowicz:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2024-09-08 11:53:48 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2303544 | ||
|
Description
Fabio Valentini
2024-09-02 13:27:40 UTC
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=122839178 Package was generated with rust2rpm, simplifying the review.
✅ package builds and installs without errors on rawhide
✅ test suite is run but there seem to be not tests
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license files are included with %license in %files
✅ package complies with Rust Packaging Guidelines
Package APPROVED. There is a lot of .md files in the %{crate_instdir}/doc directory. Shouldn't that be marked with %doc?
===
Recommended post-import rust-sig tasks:
- set up package on release-monitoring.org:
project: $crate
homepage: https://crates.io/crates/$crate
backend: crates.io
version scheme: semantic
version filter: alpha;beta;rc;pre
distro: Fedora
Package: rust-$crate
- add rust-sig with "commit" access as package co-maintainer
(should happen automatically)
- set bugzilla assignee overrides to @rust-sig (optional)
- track package in koschei for all built branches
(should happen automatically once rust-sig is co-maintainer)
===
BTW, could you look again at my devise package at https://bugzilla.redhat.com/show_bug.cgi?id=2296168 ?
Thank you for the review! The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-derive_more-impl FEDORA-2024-e74e35c106 (rust-derive_more0.99-0.99.18-1.fc42, rust-derive_more-1.0.0-1.fc42, and 1 more) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2024-e74e35c106 FEDORA-2024-e74e35c106 (rust-derive_more0.99-0.99.18-1.fc42, rust-derive_more-1.0.0-1.fc42, and 1 more) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report. |