Bug 2309192 - Review Request: rust-derive_more-impl - Internal implementation of derive_more crate
Summary: Review Request: rust-derive_more-impl - Internal implementation of derive_mor...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: wojnilowicz
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2303544
TreeView+ depends on / blocked
 
Reported: 2024-09-02 13:27 UTC by Fabio Valentini
Modified: 2024-09-08 11:53 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-09-08 11:53:48 UTC
Type: ---
Embargoed:
lukasz.wojnilowicz: fedora-review+


Attachments (Terms of Use)

Description Fabio Valentini 2024-09-02 13:27:40 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-derive_more-impl.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-derive_more-impl-1.0.0-1.fc40.src.rpm

Description:
Internal implementation of `derive_more` crate.

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2024-09-02 13:27:43 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=122839178

Comment 2 wojnilowicz 2024-09-03 15:19:30 UTC
Package was generated with rust2rpm, simplifying the review.

✅ package builds and installs without errors on rawhide
✅ test suite is run but there seem to be not tests
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license files are included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED. There is a lot of .md files in the %{crate_instdir}/doc directory. Shouldn't that be marked with %doc?

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

===

BTW, could you look again at my devise package at https://bugzilla.redhat.com/show_bug.cgi?id=2296168 ?

Comment 3 Fabio Valentini 2024-09-08 10:39:08 UTC
Thank you for the review!

Comment 4 Fedora Admin user for bugzilla script actions 2024-09-08 10:39:50 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-derive_more-impl

Comment 5 Fedora Update System 2024-09-08 11:50:11 UTC
FEDORA-2024-e74e35c106 (rust-derive_more0.99-0.99.18-1.fc42, rust-derive_more-1.0.0-1.fc42, and 1 more) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-e74e35c106

Comment 6 Fedora Update System 2024-09-08 11:53:48 UTC
FEDORA-2024-e74e35c106 (rust-derive_more0.99-0.99.18-1.fc42, rust-derive_more-1.0.0-1.fc42, and 1 more) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.