Bug 2310860
| Summary: | Review Request: rust-zerofrom - Trait for constructing | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ben Beasley <code> |
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | decathorpe, package-review |
| Target Milestone: | --- | Flags: | decathorpe:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | Trivial | ||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2024-09-10 17:50:49 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 2310825 | ||
| Bug Blocks: | |||
|
Description
Ben Beasley
2024-09-09 14:38:15 UTC
The generated Summary is a bit wonky, can you improve it a bit? Other than that, package looks good to me. === Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) Thanks for the review! https://release-monitoring.org/project/374329/ (In reply to Fabio Valentini from comment #1) > The generated Summary is a bit wonky, can you improve it a bit? Sure, how about this? [package] summary = "ZeroFrom trait for constructing" That restores the original summary from https://crates.io/crates/zerofrom, which was munged by the rust2rpm heuristics. The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-zerofrom (In reply to Ben Beasley from comment #2) > Thanks for the review! > > https://release-monitoring.org/project/374329/ > > (In reply to Fabio Valentini from comment #1) > > The generated Summary is a bit wonky, can you improve it a bit? > > Sure, how about this? > > [package] > summary = "ZeroFrom trait for constructing" > > That restores the original summary from https://crates.io/crates/zerofrom, > which was munged by the rust2rpm heuristics. 👍 FEDORA-2024-e57c7c915a (rust-zerofrom-0.1.4-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2024-e57c7c915a FEDORA-2024-e57c7c915a (rust-zerofrom-0.1.4-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2024-4cc51272bd (rust-utf8_iter-1.0.4-1.fc39, rust-zerofrom-0.1.4-1.fc39, and 1 more) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-4cc51272bd FEDORA-2024-04ddf212c0 (rust-utf8_iter-1.0.4-1.fc41 and rust-zerofrom-derive-0.1.4-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-04ddf212c0 FEDORA-2024-740e57ad2d (rust-utf8_iter-1.0.4-1.fc40 and rust-zerofrom-derive-0.1.4-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-740e57ad2d FEDORA-2024-04ddf212c0 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-04ddf212c0 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-04ddf212c0 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-4cc51272bd has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-4cc51272bd \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-4cc51272bd See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-740e57ad2d has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-740e57ad2d \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-740e57ad2d See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-EPEL-2024-7f67248787 (rust-utf8_iter-1.0.4-1.el9, rust-yoke-derive-0.7.4-1.el9, and 3 more) has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-7f67248787 FEDORA-2024-4cc51272bd has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-4cc51272bd \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-4cc51272bd See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-04ddf212c0 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-04ddf212c0 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-04ddf212c0 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-EPEL-2024-7f67248787 has been pushed to the Fedora EPEL 9 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-7f67248787 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-740e57ad2d has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-740e57ad2d \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-740e57ad2d See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-04ddf212c0 (rust-utf8_iter-1.0.4-1.fc41, rust-yoke-derive-0.7.4-1.fc41, and 3 more) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-EPEL-2024-7f67248787 (rust-utf8_iter-1.0.4-1.el9, rust-yoke-derive-0.7.4-1.el9, and 3 more) has been pushed to the Fedora EPEL 9 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2024-4cc51272bd (rust-utf8_iter-1.0.4-1.fc39, rust-yoke-derive-0.7.4-1.fc39, and 3 more) has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2024-740e57ad2d (rust-utf8_iter-1.0.4-1.fc40, rust-yoke-derive-0.7.4-1.fc40, and 3 more) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-EPEL-2024-ea19be9ef4 (rust-databake-0.1.8-2.el10_0, rust-databake-derive-0.1.8-2.el10_0, and 12 more) has been submitted as an update to Fedora EPEL 10.0. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-ea19be9ef4 FEDORA-EPEL-2024-ea19be9ef4 (rust-databake-0.1.8-2.el10_0, rust-databake-derive-0.1.8-2.el10_0, and 12 more) has been pushed to the Fedora EPEL 10.0 stable repository. If problem still persists, please make note of it in this bug report. |