Bug 2310860 - Review Request: rust-zerofrom - Trait for constructing
Summary: Review Request: rust-zerofrom - Trait for constructing
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: Trivial
Depends On: 2310825
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-09-09 14:38 UTC by Ben Beasley
Modified: 2024-09-28 12:23 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-09-10 17:50:49 UTC
Type: Bug
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Ben Beasley 2024-09-09 14:38:15 UTC
Spec URL: https://music.fedorapeople.org/rust-zerofrom.spec
SRPM URL: https://music.fedorapeople.org/rust-zerofrom-0.1.4-1.fc40.src.rpm

Description: ZeroFrom trait for constructing.

Fedora Account System Username: music

This is a dependency for rust-zerovec, which is needed for updating rust-idna to 1.x.

This package needs rust-zerofrom-derive, bug 2310825, in order for all feature metapackages to be installable.

The submission is the unmodified output of rust2rpm, without a configuration file.

Comment 1 Fabio Valentini 2024-09-10 16:19:56 UTC
The generated Summary is a bit wonky, can you improve it a bit?

Other than that, package looks good to me.

===

Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 2 Ben Beasley 2024-09-10 16:57:13 UTC
Thanks for the review!

https://release-monitoring.org/project/374329/

(In reply to Fabio Valentini from comment #1)
> The generated Summary is a bit wonky, can you improve it a bit?

Sure, how about this?

[package]
summary = "ZeroFrom trait for constructing"

That restores the original summary from https://crates.io/crates/zerofrom, which was munged by the rust2rpm heuristics.

Comment 3 Fedora Admin user for bugzilla script actions 2024-09-10 16:58:13 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-zerofrom

Comment 4 Fabio Valentini 2024-09-10 17:01:05 UTC
(In reply to Ben Beasley from comment #2)
> Thanks for the review!
> 
> https://release-monitoring.org/project/374329/
> 
> (In reply to Fabio Valentini from comment #1)
> > The generated Summary is a bit wonky, can you improve it a bit?
> 
> Sure, how about this?
> 
> [package]
> summary = "ZeroFrom trait for constructing"
> 
> That restores the original summary from https://crates.io/crates/zerofrom,
> which was munged by the rust2rpm heuristics.

👍

Comment 5 Fedora Update System 2024-09-10 17:48:19 UTC
FEDORA-2024-e57c7c915a (rust-zerofrom-0.1.4-1.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-e57c7c915a

Comment 6 Fedora Update System 2024-09-10 17:50:49 UTC
FEDORA-2024-e57c7c915a (rust-zerofrom-0.1.4-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 7 Fedora Update System 2024-09-11 14:17:58 UTC
FEDORA-2024-4cc51272bd (rust-utf8_iter-1.0.4-1.fc39, rust-zerofrom-0.1.4-1.fc39, and 1 more) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-4cc51272bd

Comment 8 Fedora Update System 2024-09-11 14:19:22 UTC
FEDORA-2024-04ddf212c0 (rust-utf8_iter-1.0.4-1.fc41 and rust-zerofrom-derive-0.1.4-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-04ddf212c0

Comment 9 Fedora Update System 2024-09-11 14:19:23 UTC
FEDORA-2024-740e57ad2d (rust-utf8_iter-1.0.4-1.fc40 and rust-zerofrom-derive-0.1.4-1.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-740e57ad2d

Comment 10 Fedora Update System 2024-09-12 02:19:55 UTC
FEDORA-2024-04ddf212c0 has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-04ddf212c0 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-04ddf212c0

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2024-09-12 02:40:21 UTC
FEDORA-2024-4cc51272bd has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-4cc51272bd \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-4cc51272bd

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2024-09-12 02:43:38 UTC
FEDORA-2024-740e57ad2d has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-740e57ad2d \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-740e57ad2d

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2024-09-13 15:36:17 UTC
FEDORA-EPEL-2024-7f67248787 (rust-utf8_iter-1.0.4-1.el9, rust-yoke-derive-0.7.4-1.el9, and 3 more) has been submitted as an update to Fedora EPEL 9.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-7f67248787

Comment 14 Fedora Update System 2024-09-14 01:41:11 UTC
FEDORA-2024-4cc51272bd has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-4cc51272bd \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-4cc51272bd

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 15 Fedora Update System 2024-09-14 02:29:20 UTC
FEDORA-2024-04ddf212c0 has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-04ddf212c0 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-04ddf212c0

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 16 Fedora Update System 2024-09-14 02:39:59 UTC
FEDORA-EPEL-2024-7f67248787 has been pushed to the Fedora EPEL 9 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-7f67248787

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 17 Fedora Update System 2024-09-14 03:16:27 UTC
FEDORA-2024-740e57ad2d has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-740e57ad2d \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-740e57ad2d

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 18 Fedora Update System 2024-09-22 00:15:12 UTC
FEDORA-2024-04ddf212c0 (rust-utf8_iter-1.0.4-1.fc41, rust-yoke-derive-0.7.4-1.fc41, and 3 more) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 19 Fedora Update System 2024-09-22 00:45:38 UTC
FEDORA-EPEL-2024-7f67248787 (rust-utf8_iter-1.0.4-1.el9, rust-yoke-derive-0.7.4-1.el9, and 3 more) has been pushed to the Fedora EPEL 9 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 20 Fedora Update System 2024-09-22 02:03:39 UTC
FEDORA-2024-4cc51272bd (rust-utf8_iter-1.0.4-1.fc39, rust-yoke-derive-0.7.4-1.fc39, and 3 more) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 21 Fedora Update System 2024-09-22 02:21:18 UTC
FEDORA-2024-740e57ad2d (rust-utf8_iter-1.0.4-1.fc40, rust-yoke-derive-0.7.4-1.fc40, and 3 more) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 22 Fedora Update System 2024-09-28 12:20:26 UTC
FEDORA-EPEL-2024-ea19be9ef4 (rust-databake-0.1.8-2.el10_0, rust-databake-derive-0.1.8-2.el10_0, and 12 more) has been submitted as an update to Fedora EPEL 10.0.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-ea19be9ef4

Comment 23 Fedora Update System 2024-09-28 12:23:42 UTC
FEDORA-EPEL-2024-ea19be9ef4 (rust-databake-0.1.8-2.el10_0, rust-databake-derive-0.1.8-2.el10_0, and 12 more) has been pushed to the Fedora EPEL 10.0 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.