Bug 2310825 - Review Request: rust-zerofrom-derive - Custom derive for the zerofrom crate
Summary: Review Request: rust-zerofrom-derive - Custom derive for the zerofrom crate
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: Trivial
Depends On:
Blocks: 2310860
TreeView+ depends on / blocked
 
Reported: 2024-09-09 10:53 UTC by Ben Beasley
Modified: 2024-09-28 12:23 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-09-10 13:59:53 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)
Configuration file for rust2rpm (116 bytes, text/plain)
2024-09-09 10:54 UTC, Ben Beasley
no flags Details

Description Ben Beasley 2024-09-09 10:53:14 UTC
Spec URL: https://music.fedorapeople.org/rust-zerofrom-derive.spec
SRPM URL: https://music.fedorapeople.org/rust-zerofrom-derive-0.1.4-1.fc40.src.rpm
Description: Custom derive for the zerofrom crate.
Fedora Account System Username: music

This is a dependency for rust-zerofrom (needed to ensure all of its feature metapackages are installable); that, in turn, is needed for rust-zerovec, which is needed for updating rust-idna to 1.x.

Comment 1 Ben Beasley 2024-09-09 10:54:53 UTC
Created attachment 2045917 [details]
Configuration file for rust2rpm

Removes an example to avoid a circular dependency on zerofrom itself.

Comment 2 Fabio Valentini 2024-09-09 22:08:32 UTC
Hm, this is a bit strange.

The license text in LICENSE is, as far as I can tell, a perfect match for the Unicode-3.0 license:
https://spdx.org/licenses/Unicode-3.0.html

But askalono (and licensecheck) identify it as a poor match for Unicode-DFS-2016, instead ...

Well, since the package.license Cargo.toml is defined as "Unicode-3.0" too, I assume that this is correct, and that both askalono and licensecheck are just wrong here for some reason.

===

Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 3 Ben Beasley 2024-09-10 13:34:40 UTC
Thank you for the review!

https://release-monitoring.org/project/374325/

Comment 4 Fedora Admin user for bugzilla script actions 2024-09-10 13:36:55 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-zerofrom-derive

Comment 5 Fedora Update System 2024-09-10 13:56:56 UTC
FEDORA-2024-74024f44aa (rust-zerofrom-derive-0.1.4-1.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-74024f44aa

Comment 6 Fedora Update System 2024-09-10 13:59:53 UTC
FEDORA-2024-74024f44aa (rust-zerofrom-derive-0.1.4-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 7 Fedora Update System 2024-09-10 15:04:09 UTC
FEDORA-2024-04ddf212c0 (rust-utf8_iter-1.0.4-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-04ddf212c0

Comment 8 Fedora Update System 2024-09-10 15:41:09 UTC
FEDORA-2024-740e57ad2d (rust-utf8_iter-1.0.4-1.fc40 and rust-zerofrom-derive-0.1.4-1.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-740e57ad2d

Comment 9 Fedora Update System 2024-09-11 02:27:59 UTC
FEDORA-2024-04ddf212c0 has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-04ddf212c0 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-04ddf212c0

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2024-09-11 02:57:05 UTC
FEDORA-2024-740e57ad2d has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-740e57ad2d \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-740e57ad2d

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2024-09-11 14:17:02 UTC
FEDORA-2024-4cc51272bd (rust-utf8_iter-1.0.4-1.fc39) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-4cc51272bd

Comment 12 Fedora Update System 2024-09-12 02:19:53 UTC
FEDORA-2024-04ddf212c0 has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-04ddf212c0 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-04ddf212c0

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2024-09-12 02:40:19 UTC
FEDORA-2024-4cc51272bd has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-4cc51272bd \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-4cc51272bd

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2024-09-12 02:43:36 UTC
FEDORA-2024-740e57ad2d has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-740e57ad2d \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-740e57ad2d

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 15 Fedora Update System 2024-09-13 15:36:14 UTC
FEDORA-EPEL-2024-7f67248787 (rust-utf8_iter-1.0.4-1.el9, rust-yoke-derive-0.7.4-1.el9, and 3 more) has been submitted as an update to Fedora EPEL 9.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-7f67248787

Comment 16 Fedora Update System 2024-09-14 01:41:08 UTC
FEDORA-2024-4cc51272bd has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-4cc51272bd \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-4cc51272bd

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 17 Fedora Update System 2024-09-14 02:29:18 UTC
FEDORA-2024-04ddf212c0 has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-04ddf212c0 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-04ddf212c0

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 18 Fedora Update System 2024-09-14 02:39:58 UTC
FEDORA-EPEL-2024-7f67248787 has been pushed to the Fedora EPEL 9 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-7f67248787

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 19 Fedora Update System 2024-09-14 03:16:25 UTC
FEDORA-2024-740e57ad2d has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-740e57ad2d \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-740e57ad2d

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 20 Fedora Update System 2024-09-22 00:15:10 UTC
FEDORA-2024-04ddf212c0 (rust-utf8_iter-1.0.4-1.fc41, rust-yoke-derive-0.7.4-1.fc41, and 3 more) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 21 Fedora Update System 2024-09-22 00:45:36 UTC
FEDORA-EPEL-2024-7f67248787 (rust-utf8_iter-1.0.4-1.el9, rust-yoke-derive-0.7.4-1.el9, and 3 more) has been pushed to the Fedora EPEL 9 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 22 Fedora Update System 2024-09-22 02:03:37 UTC
FEDORA-2024-4cc51272bd (rust-utf8_iter-1.0.4-1.fc39, rust-yoke-derive-0.7.4-1.fc39, and 3 more) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 23 Fedora Update System 2024-09-22 02:21:16 UTC
FEDORA-2024-740e57ad2d (rust-utf8_iter-1.0.4-1.fc40, rust-yoke-derive-0.7.4-1.fc40, and 3 more) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 24 Fedora Update System 2024-09-28 12:20:24 UTC
FEDORA-EPEL-2024-ea19be9ef4 (rust-databake-0.1.8-2.el10_0, rust-databake-derive-0.1.8-2.el10_0, and 12 more) has been submitted as an update to Fedora EPEL 10.0.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-ea19be9ef4

Comment 25 Fedora Update System 2024-09-28 12:23:40 UTC
FEDORA-EPEL-2024-ea19be9ef4 (rust-databake-0.1.8-2.el10_0, rust-databake-derive-0.1.8-2.el10_0, and 12 more) has been pushed to the Fedora EPEL 10.0 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.