Bug 231441
| Summary: | Review Request: aspell-pa - Aspell Punjabi Dictionary | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | A S Alam <aalam> | ||||
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> | ||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Package Reviews List <fedora-package-review> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | mshao | ||||
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2007-03-22 03:48:19 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
A S Alam
2007-03-08 12:04:08 UTC
Mock build output is fine.
But rpmlint output on SRPM gave
W: aspell-pa rpm-buildroot-usage %build DEST_DIR = $RPM_BUILD_ROOT
$RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it
will break short circuiting.
W: aspell-pa rpm-buildroot-usage %build dictdir =
${RPM_BUILD_ROOT}%{_libdir}/aspell-0.60
$RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it
will break short circuiting.
W: aspell-pa rpm-buildroot-usage %build datadir =
${RPM_BUILD_ROOT}%{_libdir}/aspell-0.60
$RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it
will break short circuiting.
And the usual output assumed on aspell rpms also reported on this package RPM
E: aspell-pa no-binary
The package should be of the noarch architecture because it doesn't contain
any binaries.
E: aspell-pa only-non-binary-in-usr-lib
There are only non binary files in /usr/lib so they should be in /usr/share.
Created attachment 149668 [details]
Modified Clean SPEC file
Use this SPEC file and resubmit the package.
thanks following is link SPEC: http://punjabi.sourceforge.net/dict/aspell-pa.spec SRPM: http://punjabi.sourceforge.net/dict/aspell-pa-0.01-1.src.rpm thanks Review: + package builds in mock (development i386). - rpmlint is NOT silent for SRPM and RPM. But following messages are ignorable E: aspell-pa no-binary E: aspell-pa only-non-binary-in-usr-lib E: aspell-pa configure-without-libdir-spec + SPEC file contains explanation about above warnings. + source files match upstream. de336d6ef55ad6fa81f8903765c6c95d aspell6-pa-0.01-1.tar.bz2 + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is small; no -doc subpackage required. + %doc does not affect runtime. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + Requires: aspell >= 12:0.60 + Provides: aspell-pa = 0.01-1 + Not a GUI APP. APPROVED. You need to follow http://fedoraproject.org/wiki/CVSAdminProcedure to request the cvs module and branches. New Package CVS Request ======================= Package Name: aspell-pa Short Description: Punjabi Dictionary for Aspell Owners: aalam Branches: devel InitialCC: aalam Please don't put the same person in both owner and intialcc. ok, thanks, changed New Package CVS Request ======================= Package Name: aspell-pa Short Description: Punjabi Dictionary for Aspell Owners: aalam Branches: devel InitialCC: panemade Package is available with following details: aspell-pa.i386 0.01-1.fc7 Package Change Request ====================== Package Name: aspell-pa New Branches: EL-4 EL-5 cvs done. |