Bug 231441 - Review Request: aspell-pa - Aspell Punjabi Dictionary
Review Request: aspell-pa - Aspell Punjabi Dictionary
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Parag AN(पराग)
Fedora Package Reviews List
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-03-08 07:04 EST by A S Alam
Modified: 2013-07-02 20:43 EDT (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-03-21 23:48:19 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
panemade: fedora‑review+
kevin: fedora‑cvs+


Attachments (Terms of Use)
Modified Clean SPEC file (1.48 KB, application/octet-stream)
2007-03-08 23:48 EST, Parag AN(पराग)
no flags Details

  None (edit)
Description A S Alam 2007-03-08 07:04:08 EST
Spec URL:http://punjabi.sourceforge.net/dict/aspell-pa.spec
SRPM URL: http://punjabi.sourceforge.net/dict/aspell-pa-0.01-1.src.rpm
Description: Aspell dictionary for Punjabi
SOURCE tar files:
ftp://ftp.gnu.org/gnu/aspell/dict/0index.html
Comment 1 Parag AN(पराग) 2007-03-08 07:22:38 EST
Mock build output is fine.
But rpmlint output on SRPM gave
W: aspell-pa rpm-buildroot-usage %build DEST_DIR = $RPM_BUILD_ROOT
$RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it
will break short circuiting.

W: aspell-pa rpm-buildroot-usage %build dictdir =
${RPM_BUILD_ROOT}%{_libdir}/aspell-0.60
$RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it
will break short circuiting.

W: aspell-pa rpm-buildroot-usage %build datadir =
${RPM_BUILD_ROOT}%{_libdir}/aspell-0.60
$RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it
will break short circuiting.

And the usual output assumed on aspell rpms also reported on this package RPM
E: aspell-pa no-binary
The package should be of the noarch architecture because it doesn't contain
any binaries.

E: aspell-pa only-non-binary-in-usr-lib
There are only non binary files in /usr/lib so they should be in /usr/share.


Comment 2 Parag AN(पराग) 2007-03-08 23:48:08 EST
Created attachment 149668 [details]
Modified Clean SPEC file 

Use this SPEC file and resubmit the package.
Comment 3 A S Alam 2007-03-09 00:47:51 EST
thanks
following is link
SPEC:
http://punjabi.sourceforge.net/dict/aspell-pa.spec

SRPM:
http://punjabi.sourceforge.net/dict/aspell-pa-0.01-1.src.rpm

thanks
Comment 4 Parag AN(पराग) 2007-03-09 01:03:43 EST
Review:
+ package builds in mock (development i386).
- rpmlint is NOT silent for SRPM and RPM.
  But following messages are ignorable
  E: aspell-pa no-binary
  E: aspell-pa only-non-binary-in-usr-lib
  E: aspell-pa configure-without-libdir-spec
+ SPEC file contains explanation about above warnings.
+ source files match upstream.
de336d6ef55ad6fa81f8903765c6c95d  aspell6-pa-0.01-1.tar.bz2
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is small; no -doc subpackage required.
+ %doc does not affect runtime.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Requires: aspell >= 12:0.60
+ Provides: aspell-pa = 0.01-1
+ Not a GUI APP.

APPROVED.
Comment 5 Jens Petersen 2007-03-09 08:26:30 EST
You need to follow http://fedoraproject.org/wiki/CVSAdminProcedure
to request the cvs module and branches.
Comment 6 A S Alam 2007-03-12 04:42:21 EDT
New Package CVS Request
=======================
Package Name: aspell-pa
Short Description: Punjabi Dictionary for Aspell
Owners: aalam@redhat.com
Branches: devel
InitialCC: aalam@redhat.com
Comment 7 Warren Togami 2007-03-13 00:04:40 EDT
Please don't put the same person in both owner and intialcc.
Comment 8 A S Alam 2007-03-13 00:27:36 EDT
ok, thanks, changed
 New Package CVS Request
=======================
Package Name: aspell-pa
Short Description: Punjabi Dictionary for Aspell
Owners: aalam@redhat.com
Branches: devel
InitialCC: panemade@gmail.com
Comment 9 A S Alam 2007-03-21 23:48:19 EDT
Package is available with following details:
aspell-pa.i386                           0.01-1.fc7 
Comment 10 Parag AN(पराग) 2008-08-12 00:56:46 EDT
Package Change Request
======================
Package Name: aspell-pa
New Branches: EL-4 EL-5
Comment 11 Kevin Fenzi 2008-08-12 01:32:41 EDT
cvs done.

Note You need to log in before you can comment on or make changes to this bug.