Bug 2318412

Summary:	Review Request: perl-Term-TermKey - Perl wrapper around libtermkey
Product:	[Fedora] Fedora	Reporter:	Emmanuel Seyman <emmanuel>
Component:	Package Review	Assignee:	Xavier Bachelot <xavier>
Status:	ASSIGNED ---	QA Contact:	Xavier Bachelot <xavier>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, ppisar, xavier
Target Milestone:	---	Flags:	ppisar: fedora-review?
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:		Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	2318410
Bug Blocks:	2283360

Description Emmanuel Seyman 2024-10-13 14:52:44 UTC

Spec URL: https://eseyman.fedorapeople.org/perl-Term-TermKey/perl-Term-TermKey.spec
SRPM URL: https://eseyman.fedorapeople.org/perl-Term-TermKey/perl-Term-TermKey-0.17-1.fc40.src.rpm
Description:
This module provides a light perl wrapper around the libtermkey library.
This library attempts to provide an abstract way to read keypress events
in terminal-based programs by providing structures that describe keys,
rather than simply returning raw bytes as read from the TTY device.

Fedora Account System Username: eseyman
Rpmlint Output: 1 packages and 1 specfiles checked; 2 errors, 0 warnings, 4 filtered, 2 badness; has taken 0.3 s

Comment 1 Xavier Bachelot 2024-10-17 18:14:42 UTC

According to tangerine, only XSLoader is runtime, all of the other currently tagged as runtime are actually buildtime, testtime are fine.

Otherwise, LGTM, although it's not buildable until perl-Alien-libtermkey hits the repo.

Comment 2 Xavier Bachelot 2024-10-21 08:25:36 UTC

Fails to build with:
Checking Alien::libtermkey atleast-version 0.16... Unable to find Alien::libtermkey providing pkg-config version 0.16

Should perl-Alien-libtermkey have a Requires: libtermkey ?
and/or perl-Term-TermKey have a BuildRequires: pkgconfig(termkey) >= 0.16 ?

Comment 3 Petr Pisar 2024-10-23 15:03:46 UTC

Yes, the meaning of Alien packages is to ensure that it is possible to build against that library. I.e. the Alien package should run-require a *-devel package of the library, and in the same version it was built against because the Alien package builds in the libraries version. See e.g. perl-Alien-pkgconf.

Comment 4 Emmanuel Seyman 2024-10-28 09:16:40 UTC

(In reply to Petr Pisar from comment #3)
>
> the Alien package should run-require a *-devel
> package of the library, and in the same version it was built against because
> the Alien package builds in the libraries version.

This is done in perl-Alien-termkey-0.22-3

Comment 5 Xavier Bachelot 2024-11-04 11:00:18 UTC

Build is failing on F42 mock. I wanted to test on F41 too, but F41 still have the older perl-Alien-termkey-0.22-2.

Test Summary Report
-------------------
t/05flags.t       (Wstat: 139 (Signal: SEGV, dumped core) Tests: 2 Failed: 0)
  Non-zero wait status: 139
  Parse errors: No plan found in TAP output
Files=11, Tests=100,  1 wallclock secs ( 0.03 usr  0.01 sys +  0.37 cusr  0.08 csys =  0.49 CPU)
Result: FAIL
Failed 1/11 test programs. 0/100 subtests failed.

Comment 6 Emmanuel Seyman 2024-11-05 23:26:52 UTC

(In reply to Xavier Bachelot from comment #5)
>
> Build is failing on F42 mock.

I will work on this tomorrow.

> I wanted to test on F41 too, but F41 still have the older perl-Alien-termkey-0.22-2.

Once this package has been approved and imported in rawhide, I'll backport both packages into F41.

Comment 7 Xavier Bachelot 2025-06-03 09:49:52 UTC

Hi Emmanuel,

Still interested in this review ?

Regards,
Xavier