Spec URL: https://eseyman.fedorapeople.org/perl-Term-TermKey/perl-Term-TermKey.spec SRPM URL: https://eseyman.fedorapeople.org/perl-Term-TermKey/perl-Term-TermKey-0.17-1.fc40.src.rpm Description: This module provides a light perl wrapper around the libtermkey library. This library attempts to provide an abstract way to read keypress events in terminal-based programs by providing structures that describe keys, rather than simply returning raw bytes as read from the TTY device. Fedora Account System Username: eseyman Rpmlint Output: 1 packages and 1 specfiles checked; 2 errors, 0 warnings, 4 filtered, 2 badness; has taken 0.3 s
According to tangerine, only XSLoader is runtime, all of the other currently tagged as runtime are actually buildtime, testtime are fine. Otherwise, LGTM, although it's not buildable until perl-Alien-libtermkey hits the repo.
Fails to build with: Checking Alien::libtermkey atleast-version 0.16... Unable to find Alien::libtermkey providing pkg-config version 0.16 Should perl-Alien-libtermkey have a Requires: libtermkey ? and/or perl-Term-TermKey have a BuildRequires: pkgconfig(termkey) >= 0.16 ?
Yes, the meaning of Alien packages is to ensure that it is possible to build against that library. I.e. the Alien package should run-require a *-devel package of the library, and in the same version it was built against because the Alien package builds in the libraries version. See e.g. perl-Alien-pkgconf.
(In reply to Petr Pisar from comment #3) > > the Alien package should run-require a *-devel > package of the library, and in the same version it was built against because > the Alien package builds in the libraries version. This is done in perl-Alien-termkey-0.22-3
Build is failing on F42 mock. I wanted to test on F41 too, but F41 still have the older perl-Alien-termkey-0.22-2. Test Summary Report ------------------- t/05flags.t (Wstat: 139 (Signal: SEGV, dumped core) Tests: 2 Failed: 0) Non-zero wait status: 139 Parse errors: No plan found in TAP output Files=11, Tests=100, 1 wallclock secs ( 0.03 usr 0.01 sys + 0.37 cusr 0.08 csys = 0.49 CPU) Result: FAIL Failed 1/11 test programs. 0/100 subtests failed.
(In reply to Xavier Bachelot from comment #5) > > Build is failing on F42 mock. I will work on this tomorrow. > I wanted to test on F41 too, but F41 still have the older perl-Alien-termkey-0.22-2. Once this package has been approved and imported in rawhide, I'll backport both packages into F41.
Hi Emmanuel, Still interested in this review ? Regards, Xavier