Bug 2326203
| Summary: | Review Request: python-proton-vpn-api-core - Expose a uniform API to available Proton VPN services | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Benson Muite <benson_muite> | ||||
| Component: | Package Review | Assignee: | Tom.Rix | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | rawhide | CC: | package-review, Tom.Rix | ||||
| Target Milestone: | --- | Flags: | Tom.Rix:
fedora-review+
|
||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2025-01-24 01:25:13 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | 2243305, 2333484 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Benson Muite
2024-11-14 10:14:20 UTC
Cannot find any valid SRPM URL for this ticket. Common causes are: - You didn't specify `SRPM URL: ...` in the ticket description or any of your comments - The URL schema isn't HTTP or HTTPS - The SRPM package linked in your URL doesn't match the package name specified in the ticket summary --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. [fedora-review-service-build] Copr build: https://copr.fedorainfracloud.org/coprs/build/8257934 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2326203-python-proton-vpn-api-core/fedora-rawhide-x86_64/08257934-python-proton-vpn-api-core/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. ok low lying fruits: Main package name must be prefixed with python, so Name: python-%{srcname} .
Source will be {forgesource0} science you are gusing forge macros
same for %prep, use %forgesetup instead
also remeber to %license the LICENSE files in % files.
Thanks. The srcname is python-proton-vpn-api-core so does not need an additional python prefix. Updated to use %forgesetup and added %license LICENSE in %files spec: https://download.copr.fedorainfracloud.org/results/fed500/python-proton-core/fedora-rawhide-x86_64/08259004-python-proton-vpn-api-core/python-proton-vpn-api-core.spec srpm: https://download.copr.fedorainfracloud.org/results/fed500/python-proton-core/fedora-rawhide-x86_64/08259004-python-proton-vpn-api-core/python-proton-vpn-api-core-0.36.6-1.fc42.src.rpm Created attachment 2057699 [details]
The .spec file difference from Copr build 8257934 to 8259014
Copr build: https://copr.fedorainfracloud.org/coprs/build/8259014 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2326203-python-proton-vpn-api-core/fedora-rawhide-x86_64/08259014-python-proton-vpn-api-core/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Looks pretty good, just change the %changelog to something meaningful like %autochangelog. Approved. The Pagure repository was created at https://src.fedoraproject.org/rpms/python-proton-vpn-api-core FEDORA-2025-71c4555b0c (python-proton-vpn-api-core-0.36.6-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2025-71c4555b0c FEDORA-2025-b9f3e4e92e (python-proton-vpn-api-core-0.36.6-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2025-b9f3e4e92e Thanks for the review. https://release-monitoring.org/project/369944/ FEDORA-2025-b9f3e4e92e has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-b9f3e4e92e \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-b9f3e4e92e See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2025-71c4555b0c has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-71c4555b0c \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-71c4555b0c See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2025-b9f3e4e92e (python-proton-vpn-api-core-0.36.6-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2025-71c4555b0c (python-proton-vpn-api-core-0.36.6-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report. |