spec: https://download.copr.fedorainfracloud.org/results/fed500/python-proton-core/fedora-rawhide-x86_64/08257516-python-proton-core/python-proton-core.spec srpm: https://download.copr.fedorainfracloud.org/results/fed500/python-proton-core/fedora-rawhide-x86_64/08257516-python-proton-core/python-proton-core-0.3.3-1.fc42.src.rpm description: The proton core component contains core logic used by the other ProtonVPN components, such as API and SSO. fas: fed500 picking up stalled review https://bugzilla.redhat.com/show_bug.cgi?id=2243305 Reproducible: Always
Copr build: https://copr.fedorainfracloud.org/coprs/build/8426265 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2333484-python-proton-core/fedora-rawhide-x86_64/08426265-python-proton-core/fedora-review/review.txt Found issues: - python3-pytest7 is deprecated, you must not depend on it. Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/deprecating-packages/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
I'm not qualified for a good review but here's what I have in mind at first glance: I suggest to replace the "python3-" package names with "python%{python3_pkgversion}".
Some minor stuff. recommend %autochangelog and %autorelease. Add %pyproject_check_import Approved. If you have time and interest, could you review python-torchsde https://bugzilla.redhat.com/show_bug.cgi?id=2334202 ? It uses python-trampoline.
Thanks for the review. Will review python-torchsde
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-proton-core
FEDORA-2024-43b59fe4e3 (python-proton-core-0.3.3-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-43b59fe4e3
FEDORA-2024-9b9f44619d (python-proton-core-0.3.3-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-9b9f44619d
FEDORA-2024-43b59fe4e3 has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-43b59fe4e3 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-43b59fe4e3 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-9b9f44619d has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-9b9f44619d \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-9b9f44619d See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-43b59fe4e3 (python-proton-core-0.3.3-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-9b9f44619d (python-proton-core-0.3.3-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.