Bug 2326203 - Review Request: python-proton-vpn-api-core - Expose a uniform API to available Proton VPN services
Summary: Review Request: python-proton-vpn-api-core - Expose a uniform API to availabl...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Tom.Rix
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2243305 2333484
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-11-14 10:14 UTC by Benson Muite
Modified: 2025-01-24 01:31 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2025-01-24 01:25:13 UTC
Type: ---
Embargoed:
Tom.Rix: fedora-review+


Attachments (Terms of Use)
The .spec file difference from Copr build 8257934 to 8259014 (753 bytes, patch)
2024-11-14 11:22 UTC, Fedora Review Service
no flags Details | Diff

Comment 1 Fedora Review Service 2024-11-14 10:14:39 UTC
Cannot find any valid SRPM URL for this ticket. Common causes are:

- You didn't specify `SRPM URL: ...` in the ticket description
  or any of your comments
- The URL schema isn't HTTP or HTTPS
- The SRPM package linked in your URL doesn't match the package name specified
  in the ticket summary


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Benson Muite 2024-11-14 10:16:42 UTC
[fedora-review-service-build]

Comment 3 Fedora Review Service 2024-11-14 10:19:18 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8257934
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2326203-python-proton-vpn-api-core/fedora-rawhide-x86_64/08257934-python-proton-vpn-api-core/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 solomoncyj 2024-11-14 10:39:58 UTC
ok low lying fruits: Main package name must be prefixed with python, so Name: python-%{srcname} . 
Source will be {forgesource0} science you are gusing forge macros
same for %prep, use %forgesetup instead 
also remeber to %license the LICENSE files in % files.

Comment 6 Fedora Review Service 2024-11-14 11:22:42 UTC
Created attachment 2057699 [details]
The .spec file difference from Copr build 8257934 to 8259014

Comment 7 Fedora Review Service 2024-11-14 11:22:44 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8259014
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2326203-python-proton-vpn-api-core/fedora-rawhide-x86_64/08259014-python-proton-vpn-api-core/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 8 Tom.Rix 2025-01-01 13:56:56 UTC
Looks pretty good, just change the %changelog to something meaningful like %autochangelog.
Approved.

Comment 9 Fedora Admin user for bugzilla script actions 2025-01-15 14:35:21 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-proton-vpn-api-core

Comment 10 Fedora Update System 2025-01-15 15:04:37 UTC
FEDORA-2025-71c4555b0c (python-proton-vpn-api-core-0.36.6-1.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-71c4555b0c

Comment 11 Fedora Update System 2025-01-15 15:05:14 UTC
FEDORA-2025-b9f3e4e92e (python-proton-vpn-api-core-0.36.6-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-b9f3e4e92e

Comment 12 Benson Muite 2025-01-15 17:07:13 UTC
Thanks for the review.

https://release-monitoring.org/project/369944/

Comment 13 Fedora Update System 2025-01-16 02:35:27 UTC
FEDORA-2025-b9f3e4e92e has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-b9f3e4e92e \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-b9f3e4e92e

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2025-01-16 02:55:25 UTC
FEDORA-2025-71c4555b0c has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-71c4555b0c \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-71c4555b0c

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 15 Fedora Update System 2025-01-24 01:25:13 UTC
FEDORA-2025-b9f3e4e92e (python-proton-vpn-api-core-0.36.6-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 16 Fedora Update System 2025-01-24 01:31:49 UTC
FEDORA-2025-71c4555b0c (python-proton-vpn-api-core-0.36.6-1.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.