Bug 2327278
| Summary: | Review Request: rust-gengo-bin - Get the language distribution stats of your repository | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ben Beasley <code> | ||||||
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | rawhide | CC: | decathorpe, package-review | ||||||
| Target Milestone: | --- | Flags: | decathorpe:
fedora-review+
|
||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| URL: | https://crates.io/crates/gengo-bin | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2025-03-21 15:59:56 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | 2326890, 2342001 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
Ben Beasley
2024-11-19 11:51:01 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/8279737 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2327278-rust-gengo-bin/fedora-rawhide-x86_64/08279737-rust-gengo-bin/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Copr build: https://copr.fedorainfracloud.org/coprs/build/8279738 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2327278-rust-gengo-bin/fedora-rawhide-x86_64/08279738-rust-gengo-bin/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Updated for 0.12.0. The man page gengo.1 reflects --color COLOR replacing --no-color. New Spec URL: https://music.fedorapeople.org/20250109/rust-gengo-bin.spec New SRPM URL: https://music.fedorapeople.org/20250109/rust-gengo-bin-0.11.5-1.fc41.src.rpm Reviewing this will require --mock-options=--enablerepo=local passed to fedora-review until the rust-gengo-0.12.0-1.fc42 update appears in a Rawhide compose. There seems to be some problem with the following file. SRPM URL: https://music.fedorapeople.org/20250109/rust-gengo-bin-0.11.5-1.fc41.src.rpm Fetching it results in a 404 Not Found error. Please make sure the URL is correct and publicly available. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Fixed URLs: New Spec URL: https://music.fedorapeople.org/20250109/rust-gengo-bin.spec New SRPM URL: https://music.fedorapeople.org/20250109/rust-gengo-bin-0.12.0-1.fc41.src.rpm Copr build: https://copr.fedorainfracloud.org/coprs/build/8494757 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2327278-rust-gengo-bin/fedora-rawhide-x86_64/08494757-rust-gengo-bin/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. [fedora-review-service-build] Copr build: https://copr.fedorainfracloud.org/coprs/build/8516746 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2327278-rust-gengo-bin/fedora-rawhide-x86_64/08516746-rust-gengo-bin/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. I need to update this to 0.12.1, which also requires rust-relative-luminance, bug 2342001, but I need to wait until rust-gix 0.70 is in Rawhide to do a test build. Actually, I was able to do a local test build after all, so: New Spec URL: https://music.fedorapeople.org/20250124/rust-gengo-bin.spec New SRPM URL: https://music.fedorapeople.org/20250124/rust-gengo-bin-0.12.1-1.fc41.src.rpm (Review will probably still have to wait for rust-gengo-0.12.1 to reach the Rawhide buildroot.) Created attachment 2073731 [details]
The .spec file difference from Copr build 8516746 to 8568214
Copr build: https://copr.fedorainfracloud.org/coprs/build/8568214 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2327278-rust-gengo-bin/fedora-rawhide-x86_64/08568214-rust-gengo-bin/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. New Spec URL: https://music.fedorapeople.org/20250305/rust-gengo-bin.spec New SRPM URL: https://music.fedorapeople.org/20250305/rust-gengo-bin-0.12.2-1.fc41.src.rpm (Review will probably still have to wait for rust-gengo-0.12.2 to reach the Rawhide buildroot.) Copr build: https://copr.fedorainfracloud.org/coprs/build/8727378 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2327278-rust-gengo-bin/fedora-rawhide-x86_64/08727378-rust-gengo-bin/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Package was generated with rust2rpm, simplifying the review. I have checked, the list generated by %cargo_license_summary when building against Rawhide today is equivalent to the list in the spec file, so no need to update the License tag. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide 🫤 test suite is run and all unit tests pass (there are no tests) ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ licenses of statically linked dependencies are correctly taken into account ✅ license files are included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter (*NOT* pre-release filter): alpha;beta;rc;pre distro: Fedora Package: rust-$crate - set bugzilla assignee overrides to @rust-sig (optional) - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) Thank you for the review! https://release-monitoring.org/project/377277/ The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-gengo-bin FEDORA-2025-d9fe41e922 (rust-gengo-bin-0.12.2-1.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-d9fe41e922 FEDORA-2025-d9fe41e922 (rust-gengo-bin-0.12.2-1.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2025-b38fb30266 (rust-gengo-bin-0.12.2-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2025-b38fb30266 FEDORA-2025-a34c67b719 (rust-gengo-bin-0.12.2-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2025-a34c67b719 FEDORA-2025-fba672ab6f (rust-gengo-bin-0.12.2-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2025-fba672ab6f FEDORA-2025-a34c67b719 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-a34c67b719 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-a34c67b719 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2025-b38fb30266 has been pushed to the Fedora 42 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-b38fb30266 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-b38fb30266 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2025-fba672ab6f has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-fba672ab6f \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-fba672ab6f See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2025-b38fb30266 (rust-gengo-bin-0.12.2-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2025-fba672ab6f (rust-gengo-bin-0.12.2-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2025-a34c67b719 (rust-gengo-bin-0.12.2-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report. |