Bug 2327278 - Review Request: rust-gengo-bin - Get the language distribution stats of your repository
Summary: Review Request: rust-gengo-bin - Get the language distribution stats of your ...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/gengo-bin
Whiteboard:
Depends On: 2326890 2342001
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-11-19 11:51 UTC by Ben Beasley
Modified: 2025-03-30 02:31 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2025-03-21 15:59:56 UTC
Type: Bug
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)
Configuration file for rust2rpm (963 bytes, text/plain)
2024-11-19 11:51 UTC, Ben Beasley
no flags Details
The .spec file difference from Copr build 8516746 to 8568214 (909 bytes, patch)
2025-01-24 19:59 UTC, Fedora Review Service
no flags Details | Diff

Description Ben Beasley 2024-11-19 11:51:01 UTC
Created attachment 2058655 [details]
Configuration file for rust2rpm

Spec URL: https://music.fedorapeople.org/rust-gengo-bin.spec
SRPM URL: https://music.fedorapeople.org/rust-gengo-bin-0.11.5-1.fc41.src.rpm
Description: Get the language distribution stats of your repository.
Fedora Account System Username: music

Comment 1 Fedora Review Service 2024-11-19 11:53:34 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8279737
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2327278-rust-gengo-bin/fedora-rawhide-x86_64/08279737-rust-gengo-bin/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fedora Review Service 2024-11-19 11:53:44 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8279738
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2327278-rust-gengo-bin/fedora-rawhide-x86_64/08279738-rust-gengo-bin/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Ben Beasley 2025-01-09 13:41:56 UTC
Updated for 0.12.0. The man page gengo.1 reflects --color COLOR replacing --no-color.

New Spec URL: https://music.fedorapeople.org/20250109/rust-gengo-bin.spec
New SRPM URL: https://music.fedorapeople.org/20250109/rust-gengo-bin-0.11.5-1.fc41.src.rpm

Reviewing this will require --mock-options=--enablerepo=local passed to fedora-review until the rust-gengo-0.12.0-1.fc42 update appears in a Rawhide compose.

Comment 4 Fedora Review Service 2025-01-09 13:42:06 UTC
There seems to be some problem with the following file.
SRPM URL: https://music.fedorapeople.org/20250109/rust-gengo-bin-0.11.5-1.fc41.src.rpm
Fetching it results in a 404 Not Found error.
Please make sure the URL is correct and publicly available.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 6 Fedora Review Service 2025-01-09 16:50:30 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8494757
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2327278-rust-gengo-bin/fedora-rawhide-x86_64/08494757-rust-gengo-bin/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 7 Ben Beasley 2025-01-15 17:37:36 UTC
[fedora-review-service-build]

Comment 8 Fedora Review Service 2025-01-15 17:47:09 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8516746
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2327278-rust-gengo-bin/fedora-rawhide-x86_64/08516746-rust-gengo-bin/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 9 Ben Beasley 2025-01-24 19:35:54 UTC
I need to update this to 0.12.1, which also requires rust-relative-luminance, bug 2342001, but I need to wait until rust-gix 0.70 is in Rawhide to do a test build.

Comment 10 Ben Beasley 2025-01-24 19:57:55 UTC
Actually, I was able to do a local test build after all, so:

New Spec URL: https://music.fedorapeople.org/20250124/rust-gengo-bin.spec
New SRPM URL: https://music.fedorapeople.org/20250124/rust-gengo-bin-0.12.1-1.fc41.src.rpm

(Review will probably still have to wait for rust-gengo-0.12.1 to reach the Rawhide buildroot.)

Comment 11 Fedora Review Service 2025-01-24 19:59:58 UTC
Created attachment 2073731 [details]
The .spec file difference from Copr build 8516746 to 8568214

Comment 12 Fedora Review Service 2025-01-24 20:00:00 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8568214
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2327278-rust-gengo-bin/fedora-rawhide-x86_64/08568214-rust-gengo-bin/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 13 Ben Beasley 2025-03-05 12:19:15 UTC
New Spec URL: https://music.fedorapeople.org/20250305/rust-gengo-bin.spec
New SRPM URL: https://music.fedorapeople.org/20250305/rust-gengo-bin-0.12.2-1.fc41.src.rpm

(Review will probably still have to wait for rust-gengo-0.12.2 to reach the Rawhide buildroot.)

Comment 14 Fedora Review Service 2025-03-05 12:21:27 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8727378
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2327278-rust-gengo-bin/fedora-rawhide-x86_64/08727378-rust-gengo-bin/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 15 Fabio Valentini 2025-03-21 14:39:50 UTC
Package was generated with rust2rpm, simplifying the review.

I have checked, the list generated by %cargo_license_summary when building against Rawhide today is equivalent to the list in the spec file, so no need to update the License tag.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
🫤 test suite is run and all unit tests pass (there are no tests)
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ licenses of statically linked dependencies are correctly taken into account
✅ license files are included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter (*NOT* pre-release filter): alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- set bugzilla assignee overrides to @rust-sig (optional)

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 16 Ben Beasley 2025-03-21 15:26:09 UTC
Thank you for the review!

https://release-monitoring.org/project/377277/

Comment 17 Fedora Admin user for bugzilla script actions 2025-03-21 15:26:37 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-gengo-bin

Comment 18 Fedora Update System 2025-03-21 15:57:27 UTC
FEDORA-2025-d9fe41e922 (rust-gengo-bin-0.12.2-1.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-d9fe41e922

Comment 19 Fedora Update System 2025-03-21 15:59:56 UTC
FEDORA-2025-d9fe41e922 (rust-gengo-bin-0.12.2-1.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 20 Fedora Update System 2025-03-21 19:31:48 UTC
FEDORA-2025-b38fb30266 (rust-gengo-bin-0.12.2-1.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-b38fb30266

Comment 21 Fedora Update System 2025-03-21 20:02:13 UTC
FEDORA-2025-a34c67b719 (rust-gengo-bin-0.12.2-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-a34c67b719

Comment 22 Fedora Update System 2025-03-21 20:27:11 UTC
FEDORA-2025-fba672ab6f (rust-gengo-bin-0.12.2-1.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-fba672ab6f

Comment 23 Fedora Update System 2025-03-22 01:50:55 UTC
FEDORA-2025-a34c67b719 has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-a34c67b719 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-a34c67b719

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 24 Fedora Update System 2025-03-22 02:23:06 UTC
FEDORA-2025-b38fb30266 has been pushed to the Fedora 42 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-b38fb30266 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-b38fb30266

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 25 Fedora Update System 2025-03-22 02:38:04 UTC
FEDORA-2025-fba672ab6f has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-fba672ab6f \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-fba672ab6f

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 26 Fedora Update System 2025-03-26 01:37:05 UTC
FEDORA-2025-b38fb30266 (rust-gengo-bin-0.12.2-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 27 Fedora Update System 2025-03-30 02:14:32 UTC
FEDORA-2025-fba672ab6f (rust-gengo-bin-0.12.2-1.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 28 Fedora Update System 2025-03-30 02:31:37 UTC
FEDORA-2025-a34c67b719 (rust-gengo-bin-0.12.2-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.