Bug 2326890 - Review Request: rust-gengo - Get the language distribution stats of your repository
Summary: Review Request: rust-gengo - Get the language distribution stats of your repo...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/gengo
Whiteboard:
Depends On:
Blocks: 2327278
TreeView+ depends on / blocked
 
Reported: 2024-11-18 04:35 UTC by Ben Beasley
Modified: 2024-12-20 13:38 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-12-08 13:22:24 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Ben Beasley 2024-11-18 04:35:39 UTC
Spec URL: https://music.fedorapeople.org/rust-gengo.spec
SRPM URL: https://music.fedorapeople.org/rust-gengo-0.11.5-1.fc41.src.rpm
Description: Get the language distribution stats of your repository.
Fedora Account System Username: music

This will be a dependency for a future release of https://src.fedoraproject.org/rpms/rust-onefetch.

This also allows packaging a command-line tool from the gengo-bin crate that provides an alternative to https://src.fedoraproject.org/rpms/rust-tokei. I haven’t posted that for review yet, but I plan to.

Comment 1 Fedora Review Service 2024-11-18 04:53:56 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8274353
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2326890-rust-gengo/fedora-rawhide-x86_64/08274353-rust-gengo/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Ben Beasley 2024-11-19 11:51:56 UTC
(In reply to Ben Beasley from comment #0)
> This also allows packaging a command-line tool from the gengo-bin crate that
> provides an alternative to https://src.fedoraproject.org/rpms/rust-tokei. I
> haven’t posted that for review yet, but I plan to.

bug 2327278

Comment 3 Fabio Valentini 2024-12-07 18:39:56 UTC
You could drop the rstest ^0.23 relaxing patch, but you don't technically need to.

===

Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass (one test that with non-shipped test data is skipped)
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version (*NOT* pre-release) filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 4 Ben Beasley 2024-12-08 12:32:56 UTC
Thank you for the review!

https://release-monitoring.org/project/375764/

Comment 5 Fedora Admin user for bugzilla script actions 2024-12-08 12:33:29 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-gengo

Comment 6 Ben Beasley 2024-12-08 12:46:20 UTC
(In reply to Fabio Valentini from comment #3)
> You could drop the rstest ^0.23 relaxing patch, but you don't technically
> need to.

Done: https://src.fedoraproject.org/rpms/rust-gengo/c/649da6a3784054d71be78e15412e8beb6c3b4b25?branch=rawhide

Comment 7 Fedora Update System 2024-12-08 13:20:18 UTC
FEDORA-2024-dcd58edd1a (rust-gengo-0.11.5-2.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-dcd58edd1a

Comment 8 Fedora Update System 2024-12-08 13:22:24 UTC
FEDORA-2024-dcd58edd1a (rust-gengo-0.11.5-2.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 9 Fedora Update System 2024-12-11 15:38:28 UTC
FEDORA-2024-0d3f796552 (rust-gengo-0.11.5-2.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-0d3f796552

Comment 10 Fedora Update System 2024-12-11 15:59:11 UTC
FEDORA-2024-9eb0a04b88 (rust-gengo-0.11.5-2.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-9eb0a04b88

Comment 11 Fedora Update System 2024-12-12 02:40:54 UTC
FEDORA-2024-0d3f796552 has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-0d3f796552 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-0d3f796552

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2024-12-12 03:49:50 UTC
FEDORA-2024-9eb0a04b88 has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-9eb0a04b88 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-9eb0a04b88

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2024-12-20 12:37:24 UTC
FEDORA-2024-9eb0a04b88 (rust-gengo-0.11.5-2.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 14 Fedora Update System 2024-12-20 13:38:25 UTC
FEDORA-2024-0d3f796552 (rust-gengo-0.11.5-2.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.