Bug 2356828 (rust-qapi-parser)

Summary: Review Request: rust-qapi-parser - QEMU QAPI JSON specification parser
Product: [Fedora] Fedora Reporter: Marc-Andre Lureau <marcandre.lureau>
Component: Package ReviewAssignee: Cole Robinson <crobinso>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: crobinso, package-review
Target Milestone: ---Keywords: AutomationTriaged
Target Release: ---Flags: crobinso: fedora-review+
Hardware: All   
OS: Linux   
URL: https://crates.io/crates/qapi-parser
Whiteboard:
Fixed In Version: Doc Type: ---
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2025-04-06 20:48:56 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2356830    
Attachments:
Description Flags
The .spec file difference from Copr build 8848007 to 8848024 none

Comment 1 Fedora Review Service 2025-04-02 07:07:52 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8848007
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2356828-rust-qapi-parser/fedora-rawhide-x86_64/08848007-rust-qapi-parser/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Fedora Review Service 2025-04-02 07:15:46 UTC
Created attachment 2083026 [details]
The .spec file difference from Copr build 8848007 to 8848024

Comment 4 Fedora Review Service 2025-04-02 07:15:48 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8848024
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2356828-rust-qapi-parser/fedora-rawhide-x86_64/08848024-rust-qapi-parser/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 5 Cole Robinson 2025-04-05 17:58:18 UTC
* spec mostly matches rust2rpm output (see comments)
+ builds on rawhide
* installs on rawhide
* content looks fine

I suggest using rust2rpm.toml to track the license handling bits, I don't see that in your repo.
Since it sounds like tests are disabled because of an upstream bug, I suggest filing an upstream issue and documenting it in the .spec file

setting fedora-review+

Comment 6 Fedora Admin user for bugzilla script actions 2025-04-06 20:07:52 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-qapi-parser

Comment 7 Marc-Andre Lureau 2025-04-06 20:36:39 UTC
(In reply to Cole Robinson from comment #5)
> I suggest using rust2rpm.toml to track the license handling bits, I don't
> see that in your repo.
> Since it sounds like tests are disabled because of an upstream bug, I
> suggest filing an upstream issue and documenting it in the .spec file
> 
> setting fedora-review+

https://github.com/arcnmx/qapi-rs/issues/27

I haven't done the rust2rpm.toml changes, they don't seem worth as hopefully upstream will address these issues for next release (after qemu release). If not, I will help or adjust rust2rpm.toml next time.

thanks

Comment 8 Fedora Update System 2025-04-06 20:45:33 UTC
FEDORA-2025-561679e7df (rust-qapi-parser-0.11.0-1.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-561679e7df

Comment 9 Fedora Update System 2025-04-06 20:48:56 UTC
FEDORA-2025-561679e7df (rust-qapi-parser-0.11.0-1.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.