Bug 2356828 (rust-qapi-parser) - Review Request: rust-qapi-parser - QEMU QAPI JSON specification parser
Summary: Review Request: rust-qapi-parser - QEMU QAPI JSON specification parser
Keywords:
Status: CLOSED ERRATA
Alias: rust-qapi-parser
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Cole Robinson
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/qapi-parser
Whiteboard:
Depends On:
Blocks: rust-qapi-codegen
TreeView+ depends on / blocked
 
Reported: 2025-04-02 07:05 UTC by Marc-Andre Lureau
Modified: 2025-04-06 20:48 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2025-04-06 20:48:56 UTC
Type: ---
Embargoed:
crobinso: fedora-review+


Attachments (Terms of Use)
The .spec file difference from Copr build 8848007 to 8848024 (307 bytes, patch)
2025-04-02 07:15 UTC, Fedora Review Service
no flags Details | Diff

Comment 1 Fedora Review Service 2025-04-02 07:07:52 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8848007
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2356828-rust-qapi-parser/fedora-rawhide-x86_64/08848007-rust-qapi-parser/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Fedora Review Service 2025-04-02 07:15:46 UTC
Created attachment 2083026 [details]
The .spec file difference from Copr build 8848007 to 8848024

Comment 4 Fedora Review Service 2025-04-02 07:15:48 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8848024
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2356828-rust-qapi-parser/fedora-rawhide-x86_64/08848024-rust-qapi-parser/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 5 Cole Robinson 2025-04-05 17:58:18 UTC
* spec mostly matches rust2rpm output (see comments)
+ builds on rawhide
* installs on rawhide
* content looks fine

I suggest using rust2rpm.toml to track the license handling bits, I don't see that in your repo.
Since it sounds like tests are disabled because of an upstream bug, I suggest filing an upstream issue and documenting it in the .spec file

setting fedora-review+

Comment 6 Fedora Admin user for bugzilla script actions 2025-04-06 20:07:52 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-qapi-parser

Comment 7 Marc-Andre Lureau 2025-04-06 20:36:39 UTC
(In reply to Cole Robinson from comment #5)
> I suggest using rust2rpm.toml to track the license handling bits, I don't
> see that in your repo.
> Since it sounds like tests are disabled because of an upstream bug, I
> suggest filing an upstream issue and documenting it in the .spec file
> 
> setting fedora-review+

https://github.com/arcnmx/qapi-rs/issues/27

I haven't done the rust2rpm.toml changes, they don't seem worth as hopefully upstream will address these issues for next release (after qemu release). If not, I will help or adjust rust2rpm.toml next time.

thanks

Comment 8 Fedora Update System 2025-04-06 20:45:33 UTC
FEDORA-2025-561679e7df (rust-qapi-parser-0.11.0-1.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-561679e7df

Comment 9 Fedora Update System 2025-04-06 20:48:56 UTC
FEDORA-2025-561679e7df (rust-qapi-parser-0.11.0-1.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.