Bug 2363932

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8994458
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2363932-perl-extutils-builder-compiler/fedora-rawhide-x86_64/08994458-perl-ExtUtils-Builder-Compiler/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

BuildRequires
FIX: Add build-require 'coreutils' it is needed for %{_fixperms}
FIX: Please add build-requires
     - perl(Config) - t/40-autodetect-executable.t:8
TODO: Please add version restriction for perl(ExtUtils::MakeMaker) >= 6.76
      NO_PACKLIST is provided since this version.

$ rpm -qp --requires perl-ExtUtils-Builder-Compiler-0.031-2.fc43.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(Carp)
      1 perl(ExtUtils::Builder) >= 0.016
      1 perl(ExtUtils::Builder::Action::Command)
      1 perl(ExtUtils::Builder::ArgumentCollector)
      1 perl(ExtUtils::Builder::AutoDetect::C)
      1 perl(ExtUtils::Builder::Binary)
      1 perl(ExtUtils::Builder::Compiler)
      1 perl(ExtUtils::Builder::Linker)
      1 perl(ExtUtils::Builder::Linker::COFF)
      1 perl(ExtUtils::Builder::Linker::ELF::Any)
      1 perl(ExtUtils::Builder::Linker::Unixy)
      1 perl(ExtUtils::Builder::MultiLingual)
      1 perl(ExtUtils::Builder::Node)
      1 perl(ExtUtils::Builder::Planner)
      1 perl(ExtUtils::Builder::Planner) >= 0.007
      1 perl(ExtUtils::Builder::Planner::Extension)
      1 perl(ExtUtils::Builder::Util)
      2 perl(ExtUtils::Config) >= 0.007
      2 perl(ExtUtils::Helpers) >= 0.027
      1 perl(File::Basename)
      1 perl(File::Spec::Functions)
      1 perl(File::Temp)
      1 perl-libs
      1 perl(parent)
      1 perl(Perl::OSType)
      1 perl(sort)
      1 perl(strict)
      1 perl(warnings)
FIX: Add run-require
     - perl(DynaLoader) - lib/ExtUtils/Builder/ParseXS.pm:72
FIX: Remove duplicit run-requires:
     - perl(ExtUtils::Config) >= 0.007
     - perl(ExtUtils::Helpers) >= 0.027

Otherwise binary requires are Ok.

$ rpm -qp --provides perl-ExtUtils-Builder-Compiler-0.031-2.fc43.noarch.rpm | sort | uniq -c
      1 perl(ExtUtils::Builder::ArgumentCollector) = 0.031
      1 perl(ExtUtils::Builder::AutoDetect::C) = 0.031
      1 perl(ExtUtils::Builder::AutoDetect::Cpp) = 0.031 
      1 perl(ExtUtils::Builder::Binary) = 0.031
      1 perl(ExtUtils::Builder::Compiler) = 0.031
      1 perl-ExtUtils-Builder-Compiler = 0.031-2.fc43
      1 perl(ExtUtils::Builder::Compiler::MSVC) = 0.031
      1 perl(ExtUtils::Builder::Compiler::Unixy) = 0.031
      1 perl(ExtUtils::Builder::Compiler::VMS) = 0.031
      1 perl(ExtUtils::Builder::Conf) = 0.031
      1 perl(ExtUtils::Builder::Linker) = 0.031
      1 perl(ExtUtils::Builder::Linker::Ar) = 0.031
      1 perl(ExtUtils::Builder::Linker::COFF) = 0.031
      1 perl(ExtUtils::Builder::Linker::ELF::Any) = 0.031
      1 perl(ExtUtils::Builder::Linker::ELF::GCC) = 0.031
      1 perl(ExtUtils::Builder::Linker::Mach::GCC) = 0.031
      1 perl(ExtUtils::Builder::Linker::PE::GCC) = 0.031
      1 perl(ExtUtils::Builder::Linker::PE::MSVC) = 0.031
      1 perl(ExtUtils::Builder::Linker::Unixy) = 0.031
      1 perl(ExtUtils::Builder::Linker::XCOFF) = 0.031
      1 perl(ExtUtils::Builder::MultiLingual) = 0.031
      1 perl(ExtUtils::Builder::ParseXS) = 0.031
      1 perl(ExtUtils::Builder::Profile::Perl) = 0.031
Binary provides are Ok.

$ rpmlint ./perl-ExtUtils-Builder-Compiler*
============================ rpmlint session starts ============================
rpmlint: 2.6.1
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 3
 2 packages and 1 specfiles checked; 0 errors, 0 warnings, 8 filtered, 0 badness; has taken 0.2 s

Rpmlint is ok

TODO: Explicitly name packaged files in %{_mandir}/man* and %{perl_vendorlib} directories
      https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists.

Otherwise the package is in line with Fedora and Perl packaging guide lines.
Please correct all 'FIX' items, consider fixing 'TODO' items and provide a new spec file.

Resolution:
NOT Approved

(In reply to Jitka Plesnikova from comment #2)
> FIX: Add build-require 'coreutils' it is needed for %{_fixperms}
> FIX: Please add build-requires
>      - perl(Config) - t/40-autodetect-executable.t:8
> TODO: Please add version restriction for perl(ExtUtils::MakeMaker) >= 6.76
>       NO_PACKLIST is provided since this version.
> FIX: Add run-require
>      - perl(DynaLoader) - lib/ExtUtils/Builder/ParseXS.pm:72
> FIX: Remove duplicit run-requires:
>      - perl(ExtUtils::Config) >= 0.007
>      - perl(ExtUtils::Helpers) >= 0.027
> TODO: Explicitly name packaged files in %{_mandir}/man* and
> %{perl_vendorlib} directories

The above items are all fixed:

Spec URL: https://cra.fedorapeople.org/perl-ExtUtils-Builder-Compiler/perl-ExtUtils-Builder-Compiler.spec
SRPM URL: https://cra.fedorapeople.org/perl-ExtUtils-Builder-Compiler/perl-ExtUtils-Builder-Compiler-0.031-3.fc43.src.rpm

Thanks.

There seems to be some problem with the following file.
SRPM URL: https://cra.fedorapeople.org/perl-ExtUtils-Builder-Compiler/perl-ExtUtils-Builder-Compiler-0.031-3.fc43.src.rpm
Fetching it results in a 404 Not Found error.
Please make sure the URL is correct and publicly available.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Corrected URLs:

Spec URL: https://cra.fedorapeople.org/perl-ExtUtils-Builder-Compiler/perl-ExtUtils-Builder-Compiler.spec
SRPM URL: https://cra.fedorapeople.org/perl-ExtUtils-Builder-Compiler/perl-ExtUtils-Builder-Compiler-0.031-3.fc44.src.rpm

(In reply to Fedora Review Service from comment #4)
> There seems to be some problem with the following file.
> SRPM URL:
> https://cra.fedorapeople.org/perl-ExtUtils-Builder-Compiler/perl-ExtUtils-
> Builder-Compiler-0.031-3.fc43.src.rpm
> Fetching it results in a 404 Not Found error.
> Please make sure the URL is correct and publicly available.

Copr build:
https://copr.fedorainfracloud.org/coprs/build/9450912
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2363932-perl-extutils-builder-compiler/fedora-rawhide-x86_64/09450912-perl-ExtUtils-Builder-Compiler/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

(In reply to Charles R. Anderson from comment #3)
> (In reply to Jitka Plesnikova from comment #2)
> > FIX: Add build-require 'coreutils' it is needed for %{_fixperms}
> > FIX: Please add build-requires
> >      - perl(Config) - t/40-autodetect-executable.t:8
> > TODO: Please add version restriction for perl(ExtUtils::MakeMaker) >= 6.76
> >       NO_PACKLIST is provided since this version.
> > FIX: Add run-require
> >      - perl(DynaLoader) - lib/ExtUtils/Builder/ParseXS.pm:72
> > FIX: Remove duplicit run-requires:
> >      - perl(ExtUtils::Config) >= 0.007
> >      - perl(ExtUtils::Helpers) >= 0.027
> > TODO: Explicitly name packaged files in %{_mandir}/man* and
> > %{perl_vendorlib} directories
> 
> The above items are all fixed:

8a11
+ BuildRequires:  coreutils
15a19
+ BuildRequires:  perl(Config)
26c30
- BuildRequires:  perl(ExtUtils::MakeMaker)
---
+ BuildRequires:  perl(ExtUtils::MakeMaker) >= 6.76
39,40c43
- Requires:       perl(ExtUtils::Config) >= 0.007
- Requires:       perl(ExtUtils::Helpers) >= 0.027
---
+ Requires:       perl(DynaLoader)
66,67c69,71
- %{perl_vendorlib}/*
- %{_mandir}/man3/*
---
+ %dir %{perl_vendorlib}/ExtUtils
+ %{perl_vendorlib}/ExtUtils/Builder
+ %{_mandir}/man3/ExtUtils::Builder*

The changes look good.

Resolution:
Approved

The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-ExtUtils-Builder-Compiler

FEDORA-2025-c784200a53 (perl-ExtUtils-Builder-Compiler-0.031-3.fc44) has been submitted as an update to Fedora 44.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-c784200a53

FEDORA-2025-77febb7f1a (perl-ExtUtils-Builder-Compiler-0.031-3.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-77febb7f1a

FEDORA-2025-601ac1de0d (perl-ExtUtils-Builder-Compiler-0.031-3.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-601ac1de0d

FEDORA-2025-a1f5789e7c (perl-ExtUtils-Builder-Compiler-0.031-3.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-a1f5789e7c

FEDORA-2025-77febb7f1a has been pushed to the Fedora 43 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-77febb7f1a \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-77febb7f1a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2025-601ac1de0d has been pushed to the Fedora 42 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-601ac1de0d \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-601ac1de0d

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2025-a1f5789e7c has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-a1f5789e7c \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-a1f5789e7c

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2025-a1f5789e7c (perl-ExtUtils-Builder-Compiler-0.031-3.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2025-601ac1de0d (perl-ExtUtils-Builder-Compiler-0.031-3.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2025-77febb7f1a (perl-ExtUtils-Builder-Compiler-0.031-3.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.