Bug 2363933 - Review Request: perl-Dist-Build - Modern module builder with author tools not included
Summary: Review Request: perl-Dist-Build - Modern module builder with author tools not...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL: https://metacpan.org/dist/Dist-Build
Whiteboard:
Depends On: 2363929 2363931 2363932
Blocks: 2302471 2387789
TreeView+ depends on / blocked
 
Reported: 2025-05-04 06:19 UTC by Charles R. Anderson
Modified: 2025-09-12 19:22 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2025-08-27 00:56:48 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Charles R. Anderson 2025-05-04 06:19:02 UTC
Spec URL: https://cra.fedorapeople.org/perl-Dist-Build/perl-Dist-Build.spec
SRPM URL: https://cra.fedorapeople.org/perl-Dist-Build/perl-Dist-Build-0.020-2.fc43.src.rpm
Description: Dist::Build is a Build.PL implementation. Unlike Module::Build::Tiny it is
extensible, unlike Module::Build it uses a build graph internally which
makes it easy to combine different customizations. It's typically extended
by adding a .pl script in planner/.

Fedora Account System Username: cra

Comment 1 Fedora Review Service 2025-05-04 06:20:31 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8994505
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2363933-perl-dist-build/fedora-rawhide-x86_64/08994505-perl-Dist-Build/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Jitka Plesnikova 2025-08-11 15:38:12 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

BuildRequires 
FIX: Add build-require 'coreutils' it is needed for %{_fixperms}
FIX: Add build-require
     - perl(Config) - t/simple.t:4

$ rpm -qp --requires perl-Dist-Build-0.020-2.fc43.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(Carp)
      1 perl(CPAN::Meta)
      1 perl(CPAN::Requirements::Dynamic) >= 0.002
      1 perl(Dist::Build::Core)
      1 perl(Dist::Build::Serializer)
      2 perl(Exporter) >= 5.57
      1 perl(ExtUtils::Builder::Action::Function)
      1 perl(ExtUtils::Builder::Compiler) >= 0.028
      1 perl(ExtUtils::Builder::Node)
      2 perl(ExtUtils::Builder::Planner) >= 0.016
      1 perl(ExtUtils::Builder::Planner::Extension)
      1 perl(ExtUtils::Builder::Serializer)
      1 perl(ExtUtils::Builder::Util)
      1 perl(ExtUtils::Config)
      1 perl(ExtUtils::Helpers) >= 0.007
      2 perl(ExtUtils::Helpers) >= 0.028
      1 perl(ExtUtils::Install)
      1 perl(ExtUtils::InstallPaths)
      1 perl(ExtUtils::Manifest)
      1 perl(File::Basename)
      1 perl(File::Copy)
      1 perl(File::Find)
      1 perl(File::Path)
      1 perl(File::ShareDir::Tiny)
      1 perl(File::Spec::Functions)
      2 perl(Getopt::Long) >= 2.36
      1 perl-libs
      2 perl(List::Util) >= 1.33
      1 perl(parent)
      1 perl(Parse::CPAN::Meta)
      1 perl(strict)
      1 perl(Text::ParseWords)
      1 perl(version)
      1 perl(warnings)
FIX: Please add run-requires:
      perl(CPAN::Meta::Merge) - lib/Dist/Build.pm:134
      perl(CPAN::Requirements::Dynamic) - lib/Dist/Build/DynamicPrereqs.pm:17
      perl(Perl::OSType) - lib/Dist/Build.pm:93
      perl(Pod::Man) - lib/Dist/Build/Core.pm:309
      perl(TAP::Harness::Env) - lib/Dist/Build/Core.pm:332

FIX: Please remove duplicit run-requires:
      perl(Exporter) >= 5.57
      perl(ExtUtils::Builder::Planner) >= 0.016
      perl(ExtUtils::Helpers) >= 0.028
      perl(Getopt::Long) >= 2.36
      perl(List::Util) >= 1.33

Otherwise binary requires are ok.

$ rpm -qp --provides perl-Dist-Build-0.020-2.fc43.noarch.rpm | sort | uniq -c
      1 perl(Dist::Build) = 0.020
      1 perl-Dist-Build = 0.020-2.fc43
      1 perl(Dist::Build::Core) = 0.020
      1 perl(Dist::Build::DynamicPrereqs) = 0.020
      1 perl(Dist::Build::Serializer) = 0.020
      1 perl(Dist::Build::ShareDir) = 0.020
      1 perl(Dist::Build::XS) = 0.020
      1 perl(Dist::Build::XS::Alien) = 0.020
      1 perl(Dist::Build::XS::Conf) = 0.020
      1 perl(Dist::Build::XS::Export) = 0.020
      1 perl(Dist::Build::XS::Import) = 0.020
      1 perl(Dist::Build::XS::WriteConstants) = 0.020
Binary provides are Ok.

$ rpmlint ./*
Rpmlint is ok

TODO: Explicitly name packaged files in %{_mandir}/man* and %{perl_vendorlib} directories
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists.

Otherwise the package is in line with Fedora and Perl packaging guide lines.
Please correct all 'FIX' items, consider fixing 'TODO' items and provide a new spec file.

Resolution:
NOT Approved

Comment 3 Charles R. Anderson 2025-08-20 18:10:44 UTC
(In reply to Jitka Plesnikova from comment #2)
> FIX: Add build-require 'coreutils' it is needed for %{_fixperms}
> FIX: Add build-require
>      - perl(Config) - t/simple.t:4
> FIX: Please add run-requires:
>       perl(CPAN::Meta::Merge) - lib/Dist/Build.pm:134
>       perl(CPAN::Requirements::Dynamic) - lib/Dist/Build/DynamicPrereqs.pm:17
>       perl(Perl::OSType) - lib/Dist/Build.pm:93
>       perl(Pod::Man) - lib/Dist/Build/Core.pm:309
>       perl(TAP::Harness::Env) - lib/Dist/Build/Core.pm:332
> FIX: Please remove duplicit run-requires:
>       perl(Exporter) >= 5.57
>       perl(ExtUtils::Builder::Planner) >= 0.016
>       perl(ExtUtils::Helpers) >= 0.028
>       perl(Getopt::Long) >= 2.36
>       perl(List::Util) >= 1.33
> TODO: Explicitly name packaged files in %{_mandir}/man* and
> %{perl_vendorlib} directories

I fixed all the above issues:

Spec URL: https://cra.fedorapeople.org/perl-Dist-Build/perl-Dist-Build.spec
SRPM URL: https://cra.fedorapeople.org/perl-Dist-Build/perl-Dist-Build-0.020-3.fc44.src.rpm

Comment 4 Fedora Review Service 2025-08-20 18:13:11 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9451102
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2363933-perl-dist-build/fedora-rawhide-x86_64/09451102-perl-Dist-Build/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 5 Jitka Plesnikova 2025-08-21 14:44:16 UTC
(In reply to Charles R. Anderson from comment #3)
> (In reply to Jitka Plesnikova from comment #2)
> > FIX: Add build-require 'coreutils' it is needed for %{_fixperms}
> > FIX: Add build-require
> >      - perl(Config) - t/simple.t:4
> > FIX: Please add run-requires:
> >       perl(CPAN::Meta::Merge) - lib/Dist/Build.pm:134
> >       perl(CPAN::Requirements::Dynamic) - lib/Dist/Build/DynamicPrereqs.pm:17
> >       perl(Perl::OSType) - lib/Dist/Build.pm:93
> >       perl(Pod::Man) - lib/Dist/Build/Core.pm:309
> >       perl(TAP::Harness::Env) - lib/Dist/Build/Core.pm:332
> > FIX: Please remove duplicit run-requires:
> >       perl(Exporter) >= 5.57
> >       perl(ExtUtils::Builder::Planner) >= 0.016
> >       perl(ExtUtils::Helpers) >= 0.028
> >       perl(Getopt::Long) >= 2.36
> >       perl(List::Util) >= 1.33
> > TODO: Explicitly name packaged files in %{_mandir}/man* and
> > %{perl_vendorlib} directories
> 
> I fixed all the above issues:

10a11
+ BuildRequires:  coreutils
17a19
+ BuildRequires:  perl(Config)
64a67
+ Requires:       perl(CPAN::Meta::Merge)
66d68
- Requires:       perl(Exporter) >= 5.57
68,71c70,72
- Requires:       perl(ExtUtils::Builder::Planner) >= 0.016
- Requires:       perl(ExtUtils::Helpers) >= 0.028
- Requires:       perl(Getopt::Long) >= 2.36
- Requires:       perl(List::Util) >= 1.33
---
+ Requires:       perl(Perl::OSType)
+ Requires:       perl(Pod::Man)
+ Requires:       perl(TAP::Harness::Env)
98,99c99,102
- %{perl_vendorlib}/*
- %{_mandir}/man3/*
---
+ %dir %{perl_vendorlib}/Dist
+ %{perl_vendorlib}/Dist/Build.pm
+ %{perl_vendorlib}/Dist/Build
+ %{_mandir}/man3/Dist::Build*

The changes look good.

Resolution:
Approved

Comment 6 Fedora Admin user for bugzilla script actions 2025-08-26 19:02:56 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Dist-Build

Comment 7 Charles R. Anderson 2025-08-27 00:56:48 UTC
FEDORA-2025-ed5838dceb (perl-Dist-Build-0.020-3.fc44) has been submitted as an update to Fedora 44.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-ed5838dceb

Comment 8 Fedora Update System 2025-08-28 07:21:23 UTC
FEDORA-2025-c280d7fc69 (perl-Dist-Build-0.020-3.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-c280d7fc69

Comment 9 Fedora Update System 2025-08-28 07:22:01 UTC
FEDORA-2025-05b2d10656 (perl-Dist-Build-0.020-3.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-05b2d10656

Comment 10 Fedora Update System 2025-08-28 07:22:25 UTC
FEDORA-2025-bb6c925356 (perl-Dist-Build-0.020-3.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-bb6c925356

Comment 11 Fedora Update System 2025-08-29 01:20:39 UTC
FEDORA-2025-bb6c925356 has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-bb6c925356 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-bb6c925356

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2025-08-29 02:06:07 UTC
FEDORA-2025-c280d7fc69 has been pushed to the Fedora 43 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-c280d7fc69 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-c280d7fc69

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2025-08-29 02:27:56 UTC
FEDORA-2025-05b2d10656 has been pushed to the Fedora 42 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-05b2d10656 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-05b2d10656

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2025-09-06 02:12:27 UTC
FEDORA-2025-05b2d10656 (perl-Dist-Build-0.020-3.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 15 Fedora Update System 2025-09-06 02:37:43 UTC
FEDORA-2025-bb6c925356 (perl-Dist-Build-0.020-3.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 16 Fedora Update System 2025-09-12 19:22:34 UTC
FEDORA-2025-c280d7fc69 (perl-Dist-Build-0.020-3.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.