Bug 2363931 - Review Request: perl-ExtUtils-Builder - Abstract actions and plans for the ExtUtils-Builder framework
Summary: Review Request: perl-ExtUtils-Builder - Abstract actions and plans for the Ex...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL: https://metacpan.org/dist/ExtUtils-Bu...
Whiteboard:
Depends On:
Blocks: 2363932 2363933
TreeView+ depends on / blocked
 
Reported: 2025-05-04 05:47 UTC by Charles R. Anderson
Modified: 2025-09-12 19:21 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2025-08-27 00:57:02 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)
The .spec file difference from Copr build 8994432 to 9450913 (2.23 KB, patch)
2025-08-20 17:02 UTC, Fedora Review Service
no flags Details | Diff

Description Charles R. Anderson 2025-05-04 05:47:16 UTC
Spec URL: https://cra.fedorapeople.org/perl-ExtUtils-Builder/perl-ExtUtils-Builder.spec
SRPM URL: https://cra.fedorapeople.org/perl-ExtUtils-Builder/perl-ExtUtils-Builder-0.017-2.fc43.src.rpm
Description: Writing extensions for various build tools can be a daunting
task. This module tries to abstract steps of build processes into
reusable building blocks for creating platform and build system
agnostic executable descriptions of work.

Fedora Account System Username: cra

Comment 1 Fedora Review Service 2025-05-04 05:58:40 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8994432
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2363931-perl-extutils-builder/fedora-rawhide-x86_64/08994432-perl-ExtUtils-Builder/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Jitka Plesnikova 2025-08-11 12:01:26 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

BuildRequires
FIX: Add build-require 'coreutils' it is needed for %{_fixperms}
TODO: Please replace perl-blib by 'perl(blib)'
TODO: Please add version restriction for perl(ExtUtils::MakeMaker) >= 6.76
      NO_PACKLIST is provided since this version.

$ rpm -qp --requires perl-ExtUtils-Builder-0.017-2.fc43.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(base)
      1 perl(Carp)
      1 perl(Config)
      2 perl(Exporter) >= 5.57
      1 perl(ExtUtils::Builder::Action)
      1 perl(ExtUtils::Builder::Action::Code)
      1 perl(ExtUtils::Builder::Action::Command)
      1 perl(ExtUtils::Builder::Action::Composite)
      1 perl(ExtUtils::Builder::Action::Perl)
      1 perl(ExtUtils::Builder::Action::Primitive)
      1 perl(ExtUtils::Builder::FileSet)
      1 perl(ExtUtils::Builder::FileSet::Filter)
      1 perl(ExtUtils::Builder::FileSet::Free)
      1 perl(ExtUtils::Builder::FileSet::Subst)
      1 perl(ExtUtils::Builder::Node)
      1 perl(ExtUtils::Builder::Plan)
      1 perl(ExtUtils::Builder::Planner)
      1 perl(ExtUtils::Builder::Util)
      1 perl(ExtUtils::Config)
      1 perl(ExtUtils::Config::MakeMaker)
      2 perl(ExtUtils::MakeMaker) >= 6.68
      1 perl(ExtUtils::Manifest)
      1 perl(File::Basename)
      1 perl(File::Spec)
      1 perl(File::Spec::Unix)
      1 perl-libs
      2 perl(List::Util) >= 1.45
      1 perl(parent)
      1 perl(Scalar::Util)
      1 perl(strict)
      1 perl(Sub::Util) >= 1.40
      1 perl(version)
      1 perl(warnings)
FIX: Please remove duplicit run-requires:
      - perl(Exporter) >= 5.57
      - perl(ExtUtils::MakeMaker) >= 6.68
      - perl(List::Util) >= 1.45
FIX: Please add run-requires
      - perl(Data::Dumper) - lib/ExtUtils/Builder/Action/Command.pm:19
      - perl(Perl::OSType) - lib/ExtUtils/Builder/MakeMaker.pm:63

Otherwise binary requires are ok

$ rpm -qp --provides perl-ExtUtils-Builder-0.017-2.fc43.noarch.rpm | sort | uniq -c
      1 perl(ExtUtils::Builder) = 0.017
      1 perl-ExtUtils-Builder = 0.017-2.fc43
      1 perl(ExtUtils::Builder::Action) = 0.017
      1 perl(ExtUtils::Builder::Action::Code) = 0.017
      1 perl(ExtUtils::Builder::Action::Command) = 0.017
      1 perl(ExtUtils::Builder::Action::Composite) = 0.017
      1 perl(ExtUtils::Builder::Action::Function) = 0.017
      1 perl(ExtUtils::Builder::Action::Perl) = 0.017
      1 perl(ExtUtils::Builder::Action::Primitive) = 0.017
      1 perl(ExtUtils::Builder::FileSet) = 0.017
      1 perl(ExtUtils::Builder::FileSet::Filter) = 0.017
      1 perl(ExtUtils::Builder::FileSet::Free) = 0.017
      1 perl(ExtUtils::Builder::FileSet::Subst) = 0.017
      1 perl(ExtUtils::Builder::MakeMaker) = 0.017
      1 perl(ExtUtils::Builder::Node) = 0.017
      1 perl(ExtUtils::Builder::Plan) = 0.017
      1 perl(ExtUtils::Builder::Planner) = 0.017
      1 perl(ExtUtils::Builder::Planner::Extension) = 0.017
      1 perl(ExtUtils::Builder::Serializer) = 0.017
      1 perl(ExtUtils::Builder::Util) = 0.017
Binary provides are Ok.

$ rpmlint ./perl-ExtUtils-Builder*
============================ rpmlint session starts ============================
rpmlint: 2.6.1
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 3
 2 packages and 1 specfiles checked; 0 errors, 0 warnings, 8 filtered, 0 badness; has taken 0.3 s
Rpmlint is ok

TODO: Explicitly name packaged files in %{_mandir}/man* and %{perl_vendorlib} directories
      https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists.
E.g.
%{_mandir}/man/ExtUtils::Builder*
%{perl_vendorlib}/ExtUtils

Otherwise the package is in line with Fedora and Perl packaging guide lines.
Please correct all 'FIX' items, consider fixing 'TODO' items and provide a new spec file.

Resolution:
NOT Approved

Comment 3 Charles R. Anderson 2025-08-20 16:46:34 UTC
(In reply to Jitka Plesnikova from comment #2)
> FIX: Add build-require 'coreutils' it is needed for %{_fixperms}
> TODO: Please replace perl-blib by 'perl(blib)'
> TODO: Please add version restriction for perl(ExtUtils::MakeMaker) >= 6.76
>       NO_PACKLIST is provided since this version.
> FIX: Please remove duplicit run-requires:
>       - perl(Exporter) >= 5.57
>       - perl(ExtUtils::MakeMaker) >= 6.68
>       - perl(List::Util) >= 1.45
> FIX: Please add run-requires
>       - perl(Data::Dumper) - lib/ExtUtils/Builder/Action/Command.pm:19
>       - perl(Perl::OSType) - lib/ExtUtils/Builder/MakeMaker.pm:63
> TODO: Explicitly name packaged files in %{_mandir}/man* and
> %{perl_vendorlib} directories

The above items are all fixed:

Spec URL: https://cra.fedorapeople.org/perl-ExtUtils-Builder/perl-ExtUtils-Builder.spec
SRPM URL: https://cra.fedorapeople.org/perl-ExtUtils-Builder/perl-ExtUtils-Builder-0.017-3.fc43.src.rpm

Thanks.

Comment 4 Fedora Review Service 2025-08-20 16:46:41 UTC
There seems to be some problem with the following file.
SRPM URL: https://cra.fedorapeople.org/perl-ExtUtils-Builder/perl-ExtUtils-Builder-0.017-3.fc43.src.rpm
Fetching it results in a 404 Not Found error.
Please make sure the URL is correct and publicly available.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 5 Charles R. Anderson 2025-08-20 16:50:57 UTC
Corrected URLs:

Spec URL: https://cra.fedorapeople.org/perl-ExtUtils-Builder/perl-ExtUtils-Builder.spec
SRPM URL: https://cra.fedorapeople.org/perl-ExtUtils-Builder/perl-ExtUtils-Builder-0.017-3.fc44.src.rpm

(In reply to Fedora Review Service from comment #4)
> There seems to be some problem with the following file.
> SRPM URL:
> https://cra.fedorapeople.org/perl-ExtUtils-Builder/perl-ExtUtils-Builder-0.
> 017-3.fc43.src.rpm
> Fetching it results in a 404 Not Found error.
> Please make sure the URL is correct and publicly available.

Comment 6 Fedora Review Service 2025-08-20 17:02:21 UTC
Created attachment 2104197 [details]
The .spec file difference from Copr build 8994432 to 9450913

Comment 7 Fedora Review Service 2025-08-20 17:02:23 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9450913
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2363931-perl-extutils-builder/fedora-rawhide-x86_64/09450913-perl-ExtUtils-Builder/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 8 Jitka Plesnikova 2025-08-21 12:32:03 UTC
(In reply to Charles R. Anderson from comment #3)
> (In reply to Jitka Plesnikova from comment #2)
> > FIX: Add build-require 'coreutils' it is needed for %{_fixperms}
> > TODO: Please replace perl-blib by 'perl(blib)'
> > TODO: Please add version restriction for perl(ExtUtils::MakeMaker) >= 6.76
> >       NO_PACKLIST is provided since this version.
> > FIX: Please remove duplicit run-requires:
> >       - perl(Exporter) >= 5.57
> >       - perl(ExtUtils::MakeMaker) >= 6.68
> >       - perl(List::Util) >= 1.45
> > FIX: Please add run-requires
> >       - perl(Data::Dumper) - lib/ExtUtils/Builder/Action/Command.pm:19
> >       - perl(Perl::OSType) - lib/ExtUtils/Builder/MakeMaker.pm:63
> > TODO: Explicitly name packaged files in %{_mandir}/man* and
> > %{perl_vendorlib} directories
> 
> The above items are all fixed:

10a11
+ BuildRequires:  coreutils
12c13
- BuildRequires:  perl-blib
---
+ BuildRequires:  perl(blib)
23c24
- BuildRequires:  perl(ExtUtils::MakeMaker) >= 6.68
---
+ BuildRequires:  perl(ExtUtils::MakeMaker) >= 6.76
43,45d43
- Requires:       perl(Exporter) >= 5.57
- Requires:       perl(ExtUtils::MakeMaker) >= 6.68
- Requires:       perl(List::Util) >= 1.45
46a45,46
+ Requires:       perl(Data::Dumper)
+ Requires:       perl(Perl::OSType)
73,74c73,76
- %{perl_vendorlib}/*
- %{_mandir}/man3/*
---
+ %dir %{perl_vendorlib}/ExtUtils
+ %{perl_vendorlib}/ExtUtils/Builder.pm
+ %{perl_vendorlib}/ExtUtils/Builder
+ %{_mandir}/man3/ExtUtils::Builder*

The changes look good.

Resolution:
Approved

Comment 9 Fedora Admin user for bugzilla script actions 2025-08-26 19:00:07 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-ExtUtils-Builder

Comment 10 Fedora Update System 2025-08-27 00:37:35 UTC
FEDORA-2025-09e8cae4f8 (perl-ExtUtils-Builder-0.017-3.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-09e8cae4f8

Comment 11 Fedora Update System 2025-08-27 00:42:14 UTC
FEDORA-2025-fa51f6ee5a (perl-ExtUtils-Builder-0.017-3.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-fa51f6ee5a

Comment 12 Fedora Update System 2025-08-27 00:42:42 UTC
FEDORA-2025-ded6b10c2e (perl-ExtUtils-Builder-0.017-3.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-ded6b10c2e

Comment 13 Charles R. Anderson 2025-08-27 00:52:42 UTC
FEDORA-2025-1147e4828b (perl-ExtUtils-Builder-0.017-3.fc44) has been submitted as an update to Fedora 44.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-1147e4828b

Comment 14 Fedora Update System 2025-08-28 01:34:57 UTC
FEDORA-2025-09e8cae4f8 has been pushed to the Fedora 43 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-09e8cae4f8 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-09e8cae4f8

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 15 Fedora Update System 2025-08-28 01:52:22 UTC
FEDORA-2025-fa51f6ee5a has been pushed to the Fedora 42 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-fa51f6ee5a \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-fa51f6ee5a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 16 Fedora Update System 2025-08-28 02:25:40 UTC
FEDORA-2025-ded6b10c2e has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-ded6b10c2e \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-ded6b10c2e

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 17 Fedora Update System 2025-09-05 02:11:24 UTC
FEDORA-2025-ded6b10c2e (perl-ExtUtils-Builder-0.017-3.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 18 Fedora Update System 2025-09-05 02:25:23 UTC
FEDORA-2025-fa51f6ee5a (perl-ExtUtils-Builder-0.017-3.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 19 Fedora Update System 2025-09-12 19:21:56 UTC
FEDORA-2025-09e8cae4f8 (perl-ExtUtils-Builder-0.017-3.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.