Bug 237936

Summary: conman init script uses some incorrect exit codes
Product: [Fedora] Fedora Reporter: Michal Marciniszyn <mmarcini>
Component: conmanAssignee: Jarod Wilson <jarod>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: low    
Version: rawhideCC: tvujec
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2007-04-26 18:03:45 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 237933    
Bug Blocks:    

Description Michal Marciniszyn 2007-04-26 08:39:27 UTC
+++ This bug was initially created as a clone of Bug #237933 +++

Description of problem:
On several occasions, the script may end up with error code 0 even when the
service is not started. As an example line:
[ ${NETWORKING} = "no" ] && exit 0
and some others. Also the return codes do not obbey our guidlines. Also note,
that the status command of the service should always return correct value, even
if the service itself cannot be started.

Version-Release number of selected component (if applicable):
all

How reproducible:
always

Steps to Reproduce:
1. service network stop
2. service conman start/status
3. echo $?
  
Actual results:
0

Expected results:
non-zero error code due to our guidlines/status of the service

Additional info:
When fixing this bug, please obbey our init script guidelines and be sure that
status command is run correctly.
Our guidelines are on following two pages:
http://intranet.corp.redhat.com/ic/intranet/InitscriptsSpec.html
http://intranet.corp.redhat.com/ic/intranet/InitscriptGuidelines.html

For an example of the script that returns the error codes correctly and always
runs status see:
http://devserv.devel.redhat.com/~mmarcini/amd

This bug is tracked by 237789.

Comment 1 Jarod Wilson 2007-04-26 18:03:45 UTC
Updated project urls and corrected exit codes.