Bug 237936 - conman init script uses some incorrect exit codes
Summary: conman init script uses some incorrect exit codes
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: conman
Version: rawhide
Hardware: All
OS: Linux
low
low
Target Milestone: ---
Assignee: Jarod Wilson
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 237933
Blocks:
TreeView+ depends on / blocked
 
Reported: 2007-04-26 08:39 UTC by Michal Marciniszyn
Modified: 2014-02-10 23:02 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2007-04-26 18:03:45 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Michal Marciniszyn 2007-04-26 08:39:27 UTC
+++ This bug was initially created as a clone of Bug #237933 +++

Description of problem:
On several occasions, the script may end up with error code 0 even when the
service is not started. As an example line:
[ ${NETWORKING} = "no" ] && exit 0
and some others. Also the return codes do not obbey our guidlines. Also note,
that the status command of the service should always return correct value, even
if the service itself cannot be started.

Version-Release number of selected component (if applicable):
all

How reproducible:
always

Steps to Reproduce:
1. service network stop
2. service conman start/status
3. echo $?
  
Actual results:
0

Expected results:
non-zero error code due to our guidlines/status of the service

Additional info:
When fixing this bug, please obbey our init script guidelines and be sure that
status command is run correctly.
Our guidelines are on following two pages:
http://intranet.corp.redhat.com/ic/intranet/InitscriptsSpec.html
http://intranet.corp.redhat.com/ic/intranet/InitscriptGuidelines.html

For an example of the script that returns the error codes correctly and always
runs status see:
http://devserv.devel.redhat.com/~mmarcini/amd

This bug is tracked by 237789.

Comment 1 Jarod Wilson 2007-04-26 18:03:45 UTC
Updated project urls and corrected exit codes.


Note You need to log in before you can comment on or make changes to this bug.