Bug 239303
| Summary: | Review Request: libgii - Input library for GGI | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nicolas Chauvet (kwizart) <kwizart> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | Keywords: | Reopened |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
tcallawa: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-05-22 21:26:29 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 239939 | ||
|
Description
Nicolas Chauvet (kwizart)
2007-05-07 14:12:34 UTC
hey whats reason behind opening same package review request twice? Closing this duplicate bug. *** This bug has been marked as a duplicate of 239939 *** Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPMs. + source files match upstream. e002b3b3b7fae2b2558fe7ac854359b7 libgii-1.0.2.src.tar.bz2 + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. - License text is NOT included in package. + %doc is small so no need of -doc subpackage. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no static libraries. + no .pc files are present. + -devel subpackage exists. + no .la files. + no translations available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + Provides: config(libgii) = 1.0.2-1.fc7 file.so keytrans.so libgg.so.1 libgii.so.1 linux_evdev.so linux_joy.so linux_kbd.so linux_mouse.so lk201.so mouse.so null.so save.so spaceorb.so stdin.so tcp.so SHOULD: Ask upstream to include License text file in tarball. There is already one packaging draft submitted on how to request upstream to include license in their tarballs. APPROVED. New Package CVS Request ======================= Package Name: libgii Short Description: Input library for GGI Owners: kwizart Branches: FC-6 F-7 devel InitialCC: License has been requested and is now added to upstream cvs repository! It will be bundled with next release... Cvs is done. |