Bug 2443679

$ cat rust2rpm.toml 
[package]
cargo-toml-patch-comments = [
  "Bump fearless_simd to 0.4",
  "Temporarily downgrade moxcms to 0.7.5",
  "Bump indicatif to 0.18",
]
extra-patches = [
  { number = 2, file = "Upgrade-to-fearless_simd-v0.4.patch", comments = ["https://github.com/LaurenzV/hayro/pull/948"] },
]

[tests]
run = ["lib", "doc"]
comments = ["Skip tests that require external assets"]

Copr build:
https://copr.fedorainfracloud.org/coprs/build/10181346
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2443679-rust-hayro-jpeg2000/fedora-rawhide-x86_64/10181346-rust-hayro-jpeg2000/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

I "accidentally" looked into packaging this crate too (glycin added a dependency on it) and found some minor issues:

- There's a bunch of files included that should probably be excluded from published crates.
  I filed https://github.com/LaurenzV/hayro/issues/1036 for this.

- The assets/*.icc files are covered by CC0-1.0 (text included in assets/LICENSE.txt).
  I am unsure about how to best represent this in crate / package metadata.
  These ICC profiles *do* get embedded into the library when building,
  so it does affect both dependent applications *and* the license of the source code shipped in rust-hayro-jpeg2000-devel.
  As far as I can tell, we will need a patch for Cargo.toml to change the license filed to `("MIT OR Apache-2.0) AND CC0-1.0"`.

As for the other changes to Cargo.toml:

- I'll try to get moxcms updated in Fedora.
- The "indicatif" dev-dependency can be dropped and doesn't need to be bumped, it is only used in skipped tests.

Upstream released 0.3.3 with changes to drop the tests, JSON files, and Python script.
Now only adding CC0-1.0 to account for assets/*.icc is left.

Spec URL: https://dcavalca.fedorapeople.org/review/rust-hayro-jpeg2000/rust-hayro-jpeg2000.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-hayro-jpeg2000/rust-hayro-jpeg2000-0.3.3-1.fc45.src.rpm

Changelog:
- update 0.3.3
- fix license

$ cat rust2rpm.toml .
[package]
cargo-toml-patch-comments = [
  "Temporarily downgrade moxcms to 0.7.5",
  "Drop unused indicatif dev-dependency",
]

Copr build:
https://copr.fedorainfracloud.org/coprs/build/10205075
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2443679-rust-hayro-jpeg2000/fedora-rawhide-x86_64/10205075-rust-hayro-jpeg2000/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Package looks mostly OK (built ok using the RPMs from the fearless_simd review), with two caveats (one bigger, one smaller):

- Looks like the package doesn't actually contain license texts for MIT and Apache-2.0.

  It appears that I completely missed this when I filed the issue about excluding the unused stuff ( :( ),
  and rust2rpm also doesn't error out because the crate *does* contain at least one license file --
  it just doesn't include all *three* of them.

  You can include the LICENSE-APACHE and LICENSE-MIT files from here for now,
  and file a PR / issue to get them included in published crates for later:

  https://github.com/LaurenzV/hayro/raw/refs/tags/hayro-jpeg2000-v0.3.3/LICENSE-APACHE
  https://github.com/LaurenzV/hayro/raw/refs/tags/hayro-jpeg2000-v0.3.3/LICENSE-MIT

- The crate license is correctly patched, but the spec file is missing a comment for *why* this happens.

  Since CC0-1.0 is actually forbidden for code now,
  documenting that CC0-1.0 only applies to *content* under assets/ would be good.

Spec URL: https://dcavalca.fedorapeople.org/review/rust-hayro-jpeg2000/rust-hayro-jpeg2000.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-hayro-jpeg2000/rust-hayro-jpeg2000-0.3.3-1.fc45.src.rpm

Changelog:
- document assets license
- add missing license texts

$ cat rust2rpm.toml 
[package]
cargo-toml-patch-comments = [
  "Temporarily downgrade moxcms to 0.7.5",
  "Drop unused indicatif dev-dependency",
  "Update license to document that the content under assets/ under CC0-1.0",
]
extra-sources = [
  { number = 2, file = "https://github.com/LaurenzV/hayro/raw/refs/tags/%{crate}-v%{version}/LICENSE-APACHE", comments = ["https://github.com/LaurenzV/hayro/pull/1053"] },
  { number = 3, file = "https://github.com/LaurenzV/hayro/raw/refs/tags/%{crate}-v%{version}/LICENSE-MIT", comments = ["https://github.com/LaurenzV/hayro/pull/1053"] },
]

[scripts]
prep.pre = [
  "cp -p %SOURCE2 %SOURCE3 .",
]

Created attachment 2132762 [details]
The .spec file difference from Copr build 10205075 to 10205766

Copr build:
https://copr.fedorainfracloud.org/coprs/build/10205766
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2443679-rust-hayro-jpeg2000/fedora-rawhide-x86_64/10205766-rust-hayro-jpeg2000/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Thanks, looks good to me!

===

Package was generated with rust2rpm, simplifying the review.

✅❌❓🫤

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
🫤 license files are included with %license in %files:
   license text for CC0-1.0 included in published tarball,
   license texts for MIT and Apache-2.0 included from upstream for now,
   PR to include them in the next release was already merged. 🎉
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter (*NOT* pre-release filter): alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- set bugzilla assignee overrides to @rust-sig (optional)

===

Please add @rust-sig as co-maintainer with "commit" access, and / or request at least the f44 branch. I will also need this package for updating GNOME/glycin to v2.1.

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-hayro-jpeg2000

FEDORA-2026-9f38e7bbe1 (rust-hayro-jpeg2000-0.3.3-1.fc45) has been submitted as an update to Fedora 45.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-9f38e7bbe1

FEDORA-2026-9f38e7bbe1 (rust-hayro-jpeg2000-0.3.3-1.fc45) has been pushed to the Fedora 45 stable repository.
If problem still persists, please make note of it in this bug report.