Bug 246960
| Summary: | Initscript Review | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Harald Hoyer <harald> |
| Component: | iscsi-initiator-utils | Assignee: | Mike Christie <mchristi> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | low | Docs Contact: | |
| Priority: | low | ||
| Version: | 9 | CC: | agrover, dcantrell, hdegoede, mcepl, mcepl |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-10-13 18:26:20 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 436175, 436341, 437522 | ||
| Bug Blocks: | 246824 | ||
|
Description
Harald Hoyer
2007-07-05 13:52:30 UTC
Mike: What's the status of this? Could you please roll an updated package? I checked in the changes for this and rolled a new package. I ran rpmlint and still have these errors: iscsi-initiator-utils.x86_64: E: non-readable /etc/iscsi/iscsid.conf 0600 iscsi-initiator-utils.x86_64: W: summary-not-capitalized iSCSI daemon and utility programs iSCSI is the name of the protocol. iscsi-initiator-utils.x86_64: E: statically-linked-binary /sbin/iscsistart We are working on this. iscsi-initiator-utils.x86_64: W: service-default-enabled /etc/rc.d/init.d/iscsi iscsi-initiator-utils.x86_64: W: no-reload-entry /etc/rc.d/init.d/iscsi iscsi-initiator-utils.x86_64: W: service-default-enabled /etc/rc.d/init.d/iscsid iscsi-initiator-utils.x86_64: W: no-reload-entry /etc/rc.d/init.d/iscsid There is no reload, because we do not fully support it yet (it is a dangerous, so we are working on code to make it more user friendly). And it is enabled, because I thought it was before and was not sure what to do. (In reply to comment #2) > And it is enabled, because I thought it was before and was not sure what to do. I don't know how to deal with backwards compatibility, but it should certainly NOT be on when newly installed (because some package, ehm libvirt, decides that it needs iscsi-*utils -- bug 436600), moreover when it is broken (bug 436341 and bug 436175). About defaulting of the init scripts read http://fedoraproject.org/wiki/PackagingDrafts/ScriptletSnippets#head-c29cf3af4233d5fcfeba2d7a50f63587eca13db1 (yes, it is a packaging draft, but it reflects commonly viewed opinion -- see the discussion of this issue on fedora-devel (e.g., http://thread.gmane.org/gmane.linux.redhat.fedora.devel/26750/focus=26754) Changing version to '9' as part of upcoming Fedora 9 GA. More information and reason for this action is here: http://fedoraproject.org/wiki/BugZappers/HouseKeeping Short intro: I've recently begun as an iscsi-initiator-utils co-maintainer and as such I'm looking into all open bugs. The iscsi services are *vital* for systems using iscsi, so they must be enabled bu default. iscsi-initiator-utils-6.2.0.870-0.1.rc1.fc10 which will be in tomorrows rawhide has rewritten initscripts, which will silently exit with a 0 status ASAP when iscsi is not needed. This should migate any complaints as a user no longer sees any messages (when not using iscsi) and the actual time spend in the scripts is negligible (all the detection code does is 1 grep) These new scripts have been written using the template from: http://fedoraproject.org/wiki/Packaging/SysVInitScript And meet all initscript guidelines, this I'm closing this. |