Bug 2491013
| Summary: | Review Request: rust-font-awesome-as-a-crate - Font Awesome Free, packaged as a crate | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabio Valentini <decathorpe> |
| Component: | Package Review | Assignee: | Michel Lind <michel> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | package-review |
| Target Milestone: | --- | Flags: | michel:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | https://crates.io/crates/font-awesome-as-a-crate | ||
| Whiteboard: | |||
| Fixed In Version: | rust-font-awesome-as-a-crate-0.3.1-1.fc45 | Doc Type: | --- |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2026-07-02 11:48:47 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2492205 | ||
|
Description
Fabio Valentini
2026-06-20 12:12:41 UTC
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=146847582 Copr build: https://copr.fedorainfracloud.org/coprs/build/10620035 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2491013-rust-font-awesome-as-a-crate/fedora-rawhide-x86_64/10620035-rust-font-awesome-as-a-crate/fedora-review/review.txt Found issues: - License file copyright.svg is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. rust2rpm.toml contents: ``` [package] exclude-crate-files = ["released.sh"] ``` Possibly useful commentary: The crate metadata lists its license as "CC-BY-4.0 AND MIT". There is also documentation *why* this is the case in fontawesome-free-6.2.0-desktop/VENDOR.md: - Only the SVG files (and accompaniying integration code) are included in the crate archive. - The SVG files are covered by the CC-BY-4.0 license, code is covered by MIT license. - No font files are included, so the OFL-1.1 does not apply here. The fontawesome-free-6.2.0-desktop/LICENSE.txt file contains copies of all relevant license texts (MIT, CC-BY-4.0, OFL-1.1). So, as far as I can tell, this is all handled correctly by the upstream project. LGTM === Package was generated with rust2rpm, simplifying the review. Issues addressed by the reviewer: - License file copyright.svg is not marked as %license — This is not a license file, it is a logo ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged (spec & crates.io: 0.3.1) ✅ license matches upstream specification and is acceptable for Fedora (spec & Cargo.toml: CC-BY-4.0 AND MIT) ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: font-awesome-as-a-crate homepage: https://crates.io/crates/font-awesome-as-a-crate backend: crates.io version scheme: semantic version filter (*NOT* pre-release filter): alpha;beta;rc;pre distro: Fedora Package: rust-font-awesome-as-a-crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) Thank you for the review! The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-font-awesome-as-a-crate Monitoring: Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org` Imported and built: https://bodhi.fedoraproject.org/updates/FEDORA-2026-78bd6fc93a |