Bug 2492205 - Review Request: rust-mdbook-html - MdBook HTML renderer
Summary: Review Request: rust-mdbook-html - MdBook HTML renderer
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/mdbook-html
Whiteboard:
Depends On: 2491013
Blocks: 2492212
TreeView+ depends on / blocked
 
Reported: 2026-06-24 14:29 UTC by Fabio Valentini
Modified: 2026-07-07 14:12 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2026-07-07 14:12:43 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+


Attachments (Terms of Use)

Description Fabio Valentini 2026-06-24 14:29:10 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-mdbook-html.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-mdbook-html-0.5.3-1.fc44.src.rpm
Upstream URL: https://crates.io/crates/mdbook-html

Description:
MdBook HTML renderer.

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2026-06-24 14:33:57 UTC
Upstream PR to add the missing license texts:
https://github.com/rust-lang/mdBook/pull/3144

Spec file is almost entirely rust2rpm-generated (config attached below), only adding bundled() Provides for the included JavaScript libraries are not covered by the config.

Note that this slightly diverges from upstream by 1. removing the fallback to bundled Open Sans fonts if they're not installed on the system, and 2. using the system copy of the Adobe Source Code Pro font too. That way, no more fonts need to be bundled or statically embedded.

```
[package]
cargo-toml-patch-comments = [
    "update license to account for included code and content",
]
license-files = [
    "LICENSE",
    "front-end/images/LICENSE-CC-BY-4.0",
    "front-end/js/LICENSE-clipboard.js.txt",
    "front-end/js/LICENSE-highlight.js.txt",
    "front-end/searcher/LICENSE-elasticlunr.js.txt",
    "front-end/searcher/LICENSE-mark.js.txt",
]

[[package.extra-sources]]
number = 2
file = "https://github.com/rust-lang/mdBook/raw/refs/tags/v0.5.3/LICENSE"
comments = ["https://github.com/rust-lang/mdBook/pull/3135"]

[[package.extra-sources]]
number = 10
file = "https://creativecommons.org/licenses/by/4.0/legalcode.txt#/LICENSE-CC-BY-4.0"
comments = ["license covering front-end/images/favicon.{png,svg}: CC-BY-4.0"]

[[package.extra-sources]]
number = 11
file = "https://github.com/zenorocha/clipboard.js/raw/refs/tags/v2.0.5/LICENSE#/LICENSE-clipboard.js.txt"
comments = ["license covering front-end/js/clipboard.min.js: MIT"]

[[package.extra-sources]]
number = 12
file = "https://github.com/highlightjs/highlight.js/raw/refs/tags/10.1.1/LICENSE#/LICENSE-highlight.js.txt"
comments = ["license covering front-end/js/highlight.js: BSD-3-Clause"]

[[package.extra-sources]]
number = 13
file = "https://github.com/weixsong/elasticlunr.js/raw/refs/tags/v0.9.5/LICENSE#/LICENSE-elasticlunr.js.txt"
comments = ["license covering front-end/searcher/elasticlunr.min.js: MIT"]

[[package.extra-sources]]
number = 14
file = "https://github.com/julkue/mark.js/raw/refs/tags/8.11.1/LICENSE#/LICENSE-mark.js.txt"
comments = ["license covering front-end/searcher/mark.min.js: MIT"]

# https://docs.fedoraproject.org/en-US/packaging-guidelines/FontsPolicy/#_web_fonts
[[package.extra-patches]]
number = 2
file = "0001-Remove-fallback-to-bundled-WOFF2-fonts.patch"
comments = ["remove fallback to bundled WOFF2 fonts"]

[requires]
build = [
    "open-sans-fonts",
    "adobe-source-code-pro-fonts",
]
lib = [
    "open-sans-fonts",
    "adobe-source-code-pro-fonts",
]

[scripts]
prep.post = [
    "cp -pav %{SOURCE2} .",
    "cp -pav %{SOURCE10} front-end/images/LICENSE-CC-BY-4.0",
    "cp -pav %{SOURCE11} front-end/js/LICENSE-clipboard.js.txt",
    "cp -pav %{SOURCE12} front-end/js/LICENSE-highlight.js.txt",
    "cp -pav %{SOURCE13} front-end/searcher/LICENSE-elasticlunr.js.txt",
    "cp -pav %{SOURCE14} front-end/searcher/LICENSE-mark.js.txt",
    "",
    "# remove bundled WOFF2 format fonts",
    "rm -v front-end/fonts/*.woff2 front-end/fonts/*.txt",
]
```

Comment 2 Fedora Review Service 2026-06-25 00:42:15 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/10647225
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2492205-rust-mdbook-html/fedora-rawhide-x86_64/10647225-rust-mdbook-html/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Neal Gompa 2026-07-07 11:18:26 UTC
Package was (mostly) generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import tasks:

- set up package on release-monitoring.org:

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 4 Fedora Admin user for bugzilla script actions 2026-07-07 11:27:58 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-mdbook-html
Monitoring:
Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`

Comment 5 Fedora Update System 2026-07-07 13:53:30 UTC
FEDORA-2026-8d55629828 (rust-mdbook-0.5.3-2.fc45, rust-mdbook-driver-0.5.3-1.fc45, and 1 more) has been submitted as an update to Fedora 45.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-8d55629828

Comment 6 Fedora Update System 2026-07-07 14:12:43 UTC
FEDORA-2026-8d55629828 (rust-mdbook-0.5.3-2.fc45, rust-mdbook-driver-0.5.3-1.fc45, and 1 more) has been pushed to the Fedora 45 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.