Bug 2491013 - Review Request: rust-font-awesome-as-a-crate - Font Awesome Free, packaged as a crate
Summary: Review Request: rust-font-awesome-as-a-crate - Font Awesome Free, packaged as...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Michel Lind
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/font-awesome...
Whiteboard:
Depends On:
Blocks: 2492205
TreeView+ depends on / blocked
 
Reported: 2026-06-20 12:12 UTC by Fabio Valentini
Modified: 2026-07-02 11:48 UTC (History)
1 user (show)

Fixed In Version: rust-font-awesome-as-a-crate-0.3.1-1.fc45
Clone Of:
Environment:
Last Closed: 2026-07-02 11:48:47 UTC
Type: ---
Embargoed:
michel: fedora-review+


Attachments (Terms of Use)

Description Fabio Valentini 2026-06-20 12:12:41 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-font-awesome-as-a-crate.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-font-awesome-as-a-crate-0.3.1-1.fc44.src.rpm
Upstream URL: https://crates.io/crates/font-awesome-as-a-crate

Description:
Font Awesome Free, packaged as a crate.

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2026-06-20 12:12:44 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=146847582

Comment 2 Fedora Review Service 2026-06-20 12:16:31 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/10620035
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2491013-rust-font-awesome-as-a-crate/fedora-rawhide-x86_64/10620035-rust-font-awesome-as-a-crate/fedora-review/review.txt

Found issues:

- License file copyright.svg is not marked as %license
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Fabio Valentini 2026-06-20 12:20:44 UTC
rust2rpm.toml contents:

```
[package]
exclude-crate-files = ["released.sh"]
```

Possibly useful commentary:

The crate metadata lists its license as "CC-BY-4.0 AND MIT".
There is also documentation *why* this is the case in fontawesome-free-6.2.0-desktop/VENDOR.md:

- Only the SVG files (and accompaniying integration code) are included in the crate archive.
- The SVG files are covered by the CC-BY-4.0 license, code is covered by MIT license.
- No font files are included, so the OFL-1.1 does not apply here.

The fontawesome-free-6.2.0-desktop/LICENSE.txt file contains copies of all relevant license texts (MIT, CC-BY-4.0, OFL-1.1).
So, as far as I can tell, this is all handled correctly by the upstream project.

Comment 4 Michel Lind 2026-06-25 09:42:53 UTC
LGTM

===

Package was generated with rust2rpm, simplifying the review.

Issues addressed by the reviewer:
- License file copyright.svg is not marked as %license — This is not a license file, it is a logo

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged (spec & crates.io: 0.3.1)
✅ license matches upstream specification and is acceptable for Fedora (spec & Cargo.toml: CC-BY-4.0 AND MIT)
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: font-awesome-as-a-crate
  homepage: https://crates.io/crates/font-awesome-as-a-crate
  backend: crates.io
  version scheme: semantic
  version filter (*NOT* pre-release filter): alpha;beta;rc;pre
  distro: Fedora
  Package: rust-font-awesome-as-a-crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 5 Fabio Valentini 2026-07-02 11:22:50 UTC
Thank you for the review!

Comment 6 Fedora Admin user for bugzilla script actions 2026-07-02 11:24:08 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-font-awesome-as-a-crate
Monitoring:
Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`

Comment 7 Fabio Valentini 2026-07-02 11:48:47 UTC
Imported and built:
https://bodhi.fedoraproject.org/updates/FEDORA-2026-78bd6fc93a


Note You need to log in before you can comment on or make changes to this bug.