Bug 2498325
| Summary: | Review Request: pristine-tar - Regenerate pristine tarballs | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Laudin Molina <laudin.molina> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | NEW --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | laudin.molina, package-review |
| Target Milestone: | --- | Keywords: | AutomationTriaged |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://kitenet.net/~joey/code/pristine-tar/ | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | --- | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | Type: | --- | |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Laudin Molina
2026-07-08 22:53:44 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/10699662 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2498325-pristine-tar/fedora-rawhide-x86_64/10699662-pristine-tar/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Previous review request from 2015, abandoned by the original submitter. This request considers the comments in that request.
Bundled libraries (declared):
Provides: bundled(gzip) = 1.3.12
Provides: bundled(bzip2-old) = 0.9.5d
Provides: bundled(bzip2) = 1.0.6
Rationale: patched/legacy compressor snapshots needed to regenerate byte-identical historical tarballs (old gzip/bzip2/SUSE-bzip2 builds), linking against current system libraries would not reproduce the same byte-for-byte output. See previous discussion https://bugzilla.redhat.com/show_bug.cgi?id=1235404#c5
rpmlint issues:
- pristine-tar.src: E: spelling-error ('gz', '%description -l en_US gz -> g, z, gr')
False positive -- "gz" is the gzip file extension not a misspelling.
- pristine-tar.x86_64: E: spelling-error ('gz', '%description -l en_US gz -> g, z, gr')
False positive -- "gz" is the gzip file extension not a misspelling.
- pristine-tar.spec: W: no-%check-section
The test suite requires shunit2 (not in $PATH on Fedora, see https://bugzilla.redhat.com/show_bug.cgi?id=2494102) and diffoscope (uninstallable on Fedora 44 due to a dependency conflict, see https://bugzilla.redhat.com/show_bug.cgi?id=2464627). The spec files includes the relevant sections commented.
- pristine-tar.x86_64: E: incorrect-fsf-address /usr/share/licenses/pristine-tar/GPL-2.0-or-later.txt
False positive on verbatim upstream license text. The license file uses "51 Franklin Street" FSF address, which matches https://spdx.org/licenses/GPL-2.0-or-later.html.
Other issues:
- Runtime dependency on perl(Sys::CpuAffinity) that is not yet in Fedora - pending review. See https://bugzilla.redhat.com/show_bug.cgi?id=2425545. Filing this review in parallel rather than blocking on it.
This is my first package under review.
For reference, there's an ongoing effort to update and align the spec and the package in upstream. See discussion https://salsa.debian.org/debian/pristine-tar/-/merge_requests/11. |