Spec URL: http://pinky.die-welt.net/~evgeni/rpm/pristine-tar.spec SRPM URL: http://pinky.die-welt.net/~evgeni/rpm/pristine-tar-1.33-1.fc21.src.rpm Description: pristine-tar can regenerate a pristine upstream tarball using only a small binary delta file and a revision control checkout of the upstream branch. The package also includes a pristine-gz command, which can regenerate a pristine .gz file, a pristine-bz2 for .bz2 files, and a pristine-xz for .xz files. The delta file is designed to be checked into revision control along-side the upstream branch, thus allowing Debian packages to be built entirely using sources in revision control, without the need to keep copies of upstream tarballs. Fedora Account System Username: evgeni Koji builds for f21 and f22: http://koji.fedoraproject.org/koji/taskinfo?taskID=10199183 http://koji.fedoraproject.org/koji/taskinfo?taskID=10199187 rpmlint: pristine-tar.src: W: spelling-error %description -l en_US gz -> g, z, gs pristine-tar.src: W: spelling-error %description -l en_US xz -> xx, x, z pristine-tar.x86_64: W: spelling-error %description -l en_US gz -> g, z, gs pristine-tar.x86_64: W: spelling-error %description -l en_US xz -> xx, x, z (yeah, I do want to spell gz like that ;)) I am a newbie at packaging (for Fedora), so I need a sponsor and a patient one ;-)
This seems like fairly old code. Is it of particular use to you or something else? I'm also concerned that it appears to bundle gzip and bzip2 code.
Yes, it is quite old code, but it is heavily used for maintaining Debian packages in Git. I am currently discussing with a few Debian people to revive the upstream maintaineship inside of Debian. It is of use for me (and hopefully others) who want to be able to maintain Debian packages on a Fedora system (crude setup, I know). As for the bundled code, yes it is used. I can dig up the exact reason for using it (instead of bzip2-libs) later, if you want to. Reminds me to upload a slightly refreshed version with xdelta3 compatibility.
Yes, I would need to know the bundling reasons.
Bundling has been relaxed substantially in Fedora. Do you still want to pursue this review?
Hi Orion, sorry for the long delay -- work has been keeping me busy and a working pristine-tar was not top of the priorities :) The bundled bzip2 and gzip code is needed to be able to recreate byte-identical archives created with some (old) versions of these tools. Would this be OK for bundling in Fedora? If I read https://fedoraproject.org/wiki/Bundled_Software_policy correctly, I'd "just" have to add proper provides, right? Regards Evgeni
Yes, now you just need to add the provides.
Ok, cool. I have now added the following to the spec: # zgz/gzip/* Provides: bundled(gzip) = 1.3.12 # zgz/old-bzip2/* Provides: bundled(bzip2) = 0.9.5 # pit/suse-bzip2/* Provides: bundled(bzip2) = 1.0.6 Is it correct to list bzip2 as bzip2, and not as bzip2-libs or libbz2? https://fedoraproject.org/wiki/Bundled_Software_policy only says "<libname>" which is not really exact :)
rpmlint says it's an error to have the same provides twice, though: pristine-tar.x86_64: E: useless-provides bundled(bzip2) This package provides 2 times the same capacity. It should only provide it once.
Sorry for the delay here. Do you want to continue? For bzip2 I would do: Provides: bundled(bzip2-old) = 0.9.5 Provides: bundled(bzip2) = 1.0.6
I must admit I lost time and interest in pristine-tar in Fedora, so I am closing this as WONTFIX. Thanks Orion for the reviews!