Bug 249968

Summary: timidity++: $RPM_OPT_FLAGS not used, useless debuginfo package
Product: [Fedora] Fedora Reporter: Ville Skyttä <ville.skytta>
Component: timidity++Assignee: Hans de Goede <hdegoede>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: low    
Version: rawhideCC: jnovy
Target Milestone: ---Keywords: Patch, Reopened
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2007-10-14 19:41:25 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Use $RPM_OPT_FLAGS, fix -debuginfo none

Description Ville Skyttä 2007-07-28 17:51:25 UTC 
timidity++ is built without $RPM_OPT_FLAGS, and its debuginfo package is
practically useless.

Fix attached, more info: http://fedoraproject.org/wiki/Packaging/Debuginfo

The fix also moves autoconf to %prep, IMO it's a more suitable place for it than
%build, and configures with --disable-dependency-tracking for cleaner build
output and possible small build speedup.
Comment 1 Ville Skyttä 2007-07-28 17:51:25 UTC 
Created attachment 160170 [details]
Use $RPM_OPT_FLAGS, fix -debuginfo
Comment 2 Jindrich Novy 2007-10-12 14:32:35 UTC 
Fixed, thanks.
Comment 3 Ville Skyttä 2007-10-12 14:52:28 UTC 
Hm, 2.13.2-3 no longer explicitly runs autoconf at all, was that intentional? 
BuildRequires: autoconf is still there.
Comment 4 Ville Skyttä 2007-10-12 14:53:10 UTC 
(Jindrich, see comment 3)
Comment 5 Jindrich Novy 2007-10-12 16:18:01 UTC 
Ville, yes, it was intentional. It seems to work just fine without autoconf as
the configure script is sane. I forgot to remove the autoconf BR. Hans wants to
fix other bugs in timidity so I let addition or removal of the autoconf upon his
decision. He can do it altogether with other fixes in the next build.
Comment 6 Hans de Goede 2007-10-13 07:27:47 UTC 
Note: fixed in CVS, not building yet as I also want to fix bug 200688 before
building.
Comment 7 Hans de Goede 2007-10-14 19:41:25 UTC 
I've just started a build for 2.13.2-4, which fixes this, closing.